-
Notifications
You must be signed in to change notification settings - Fork 100
Bump org.glassfish.expressly:expressly from 5.0.0 to 6.0.0 #2362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dependabot
wants to merge
1
commit into
main
from
dependabot/gradle/org.glassfish.expressly-expressly-6.0.0
+1
−1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm for this one you probably want to bump it in pair with
expressly 5 + HV 8
expressly 6 + HV 9
with that said .... if HV is here just for tests ... you can always make it work without expressly:
hibernate/hibernate-orm@58d2239
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and if you want to keep expressly, then probably it would make sense to add it to the ignore rules for dependabot so that it would get updated in pair with HV to match the version it targets..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will try to remove it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the test will fail without it. I will try to see what I can do with dependabot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rigth ... you need to switch the interpolator if you want to remove the dependency... if you add the XML https://github.com/hibernate/hibernate-orm/blob/58d2239d850ad700d9348d13ca24de9ef4865887/hibernate-c3p0/src/test/resources/META-INF/validation.xml it should do the trick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and just in case you'd want to ignore the updates, here's an example from Search 🙈😃 : https://github.com/hibernate/hibernate-search/blob/9d88f870b7e33728a70969d8eaf4f0bf27cb0137/.github/dependabot.yml#L92-L95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to be notified when there's a new release, and ignore it if I'm not interested or doesn't work.
I think I will just create a group for validator with hibernate-validator and glassfish and evaluate case by case.
Considering that we only use it for testing, it should be fine to have a more relaxed rule for it.
I will re-evaluate if it becomes too much of a chore to keep it up to date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I will just lock the version to 5 until we change hibernate-validator to 9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way... why is this not the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has to do with the spec: https://jakarta.ee/specifications/bean-validation/3.1/jakarta-validation-spec-3.1#validationapi-message-defaultmessageinterpolation-expressionlanguage by default, EL must be supported.