V0.1.8 staging #149
Merged
V0.1.8 staging #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 7, 2024 20:57
The date format was ISO, eg. 2001-01-31, but with that format for display it's not apparent if the date has been entered incorrectly for RSUs where the date tends to be on the first of the month. As such this updates the format to 2021-Jan-31 so that it's utterly unambiguous for read back. Fixes #130 Fixes #129
This adds an insheet note to the Gain/Merger column that documents when it changes colour - namely, showing the lots for which the alternative gain calculation applies.
The adjustment calculation for ESPPs was incorrect on the cash-only display for non-zero values. It should be expressed as a negative and not positive number. Luckily, no ESPP lots have a non-zero adjustment, so when cash-only is selected the error isn't impactful. Fixes #136
This adds error handling to suppress NaN style errors in unused rows that otherwise cascade into visible columns.
This includes the imputed income element if an ESPP lot was converted to 100% during the merger. This does not allow someone who chose 100% cash to use the sheet without issue however, as the gain is still floored at 0 and loss is suppressed. It will suffice for ESPPs however as no lots incurred a loss...and RSUs are very simple for the 100% cash case.
Adds an averaged form of the post-merger tax basis to the summary page. This is needed for some non-US countries.
People seem confused with the true economic value display. Given the because the TurboTax and Form8949 do state to use the exact values from the 1099, I've changed the default to cash-only. I'll be following up with a CPA about the validity of differing proceeds values because it's necessary for per-lot adjustment.
This adds a per-lot post-merger tax basis column to aid with reporting when shares have been sold. For ESPP the column is the basis adjusted by imputed income. The primary reason for wanting a lot basis is due to sale in which case the adjusted basis is the one to use. Fixes #138
Also adds error handling for post-merger avg basis to avoid DIV0 error when sheet isn't populated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates and polish
2021-Jan-31to be utterly unambiguous under review - can still be entered in ISO formatFixes #133 - sort of. The attached excel sheet is configured to support iterative calculations, and I've dropped the shared O365 one for now.