Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix recording of webgl2 canvases #106

Merged
merged 7 commits into from
Jul 21, 2023
Merged

fix recording of webgl2 canvases #106

merged 7 commits into from
Jul 21, 2023

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Jul 13, 2023 •
edited
Loading

webgl2 canvases created after highlight would start recording with the preserveDrawingBuffer: false
setting would not record correctly because we would snapshot a transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with preserveDrawingBuffer: true to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo

@Vadman97 Vadman97 requested review from a team and ccschmitz and removed request for a team July 13, 2023 03:12
@Vadman97 Vadman97 mentioned this pull request Jul 13, 2023
Merged
Vadman97 added a commit to highlight/highlight that referenced this pull request Jul 19, 2023
@Vadman97
add canvas page test for tracking style mutations (#5569)
a28ff1f 
## Summary

Adding a canvas test for tracking style mutations.

Fixes rrweb to correctly record webgl2 canvases with a performance
optimization enabled (babylon.js)
highlight/rrweb#106
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded 

## How did you test this change?

Viewing /1/canvas locally

Viewing e2e next.js app canvas (babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo

## Are there any deployment considerations?

Canvas page is gated to our project.
New client released for rrweb canvas changes.
@Vadman97 Vadman97 merged commit 69263d5 into master Jul 21, 2023
Vadman97 added a commit that referenced this pull request Jan 30, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
a85a66f 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Mar 4, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
2905685 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Mar 5, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
f29f645 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Mar 5, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
791f78a 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Apr 16, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
0875773 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Apr 17, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
c4cbf67 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Jun 25, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
eca1728 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Aug 5, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
29f1605 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Aug 5, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
30f1f15 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Aug 26, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
988f533 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Sep 3, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
0667e2d 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Sep 9, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
1f09dc2 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Sep 18, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
28ff64d 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Oct 9, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
78a47cf 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Oct 9, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
27b03a0 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Oct 15, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
0f17deb 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Oct 29, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
6f69a3c 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Vadman97 added a commit that referenced this pull request Oct 29, 2024
@Vadman97
fix recording of webgl2 canvases (#106)
67c7fc3 
webgl2 canvases created after highlight would start recording with the
`preserveDrawingBuffer: false`
setting would not record correctly because we would snapshot a
transparent image of the canvas.
instead of trying to clear the canvas, we should create a context with
`preserveDrawingBuffer: true` to
ensure that the canvas can be recorded (tested in babylon.js)
https://app.highlight.io/1/sessions/n7P0x5XTItCqEN7B7pmtJVldUzJo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccschmitz ccschmitz Awaiting requested review from ccschmitz ccschmitz was automatically assigned from highlight/full-stack-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadman97