fix(haxe) fix new keyword false positives #3993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look into the markup tests sometime soon / hopefully later today. I am regex noob but I believe this should work okay! |
joshgoebel
reviewed
Feb 20, 2024
ninjamuffin99
changed the title
new keyword in haxebeginKeywords for new keyword in haxe
|
added markup tests, and changed to use |
joshgoebel
approved these changes
Feb 24, 2024
Build Size ReportChanges to minified artifacts in 12 files changedTotal change -58 B View Changes
|
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +2 B View Changes
|
joshgoebel
changed the title
beginKeywords for new keyword in haxe
joshtynjala
added a commit
to joshtynjala/highlight.js
that referenced
this pull request
Aug 29, 2025
PR highlightjs#3993 fixed incorrect highlighting of variable names starting with new, but at the same time, it removed highlighting of type names that follow the new keyword. This commits restores the lost highlighting for type names after the new keyword, while still ensuring that new at the start of a variable name is not highlighted as a keyword.
joshtynjala
added a commit
to joshtynjala/highlight.js
that referenced
this pull request
Aug 29, 2025
PR highlightjs#3993 fixed incorrect highlighting of variable names starting with new (like newValue), but at the same time, it removed highlighting of type names that follow the new keyword. This commit restores the lost highlighting for type names after the new keyword, while still ensuring that new at the start of a variable name is not highlighted as a keyword.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the regex in the haxe.js highlighting to only highlight
newas a keyword if it's not used within a variable/class name, usingbeginKeywords: 'new'instead ofnew *Resolves #3992
Changes
Chnages the regex to use
beginKeywords: 'new'instead of *, so that it can capturenewas a keyword, but not when it's used within a variable nameChecklist
CHANGES.md