types, notes, etc. (WIP) #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete it? or is it used in tests?
build just 1 xsnap, and don't clone the whole git history
why 2 objectTools? getWindowLength and getTokenQuantity are not generic object tools; they're specific to EpochDetails; why are they here?
is this needed? it's probably best
we have constants for stuff like ONE_THOUSAND where the literal is at least as clear, but not for 86_400n? (is that 1 day? 10 days?)
Merged
|
seems like this is overtaken by events, esp. #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I meant to try running the contract on a blockchain, but there's no core-eval script... and making one is complicated by #47 .
So I looked over
test-airdrop.jsand the contract, using static typing as a guide.I pruned a bunch of code that seems irrelevant.
I'm not sure how much of this you might want to actually merge, @tgrecojs .
I cleaned up the xsnap dependency.
fixes #45
I
test.skipped non-working tests, so...fixes #46