Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addressed notes #49

Merged
merged 31 commits into from
Apr 15, 2024
Merged

addressed notes #49

merged 31 commits into from
Apr 15, 2024

Conversation

tgrecojs
Copy link
Contributor

refs: #38 #47, #48

dckc and others added 30 commits April 11, 2024 00:38
@dckc
chore: prune interchain-ui/
fdd00af
@dckc
chore: prune klunky deployment scripts
2a09402
@dckc
chore: prune offer-up contract test
9e4e5b1
@dckc
chore: prune launchIt etc. power-tools contracts
cdb99c1
@dckc
chore: marshalTables not used in src (WIP)
2f35277 
delete it? or is it used in tests?
@dckc
chore: prune extra copy of test-bundle-source.js
66c587b
@dckc
chore: move offer-tool src/ -> scripts/
7acf2d2
@dckc
build: upgrade typescript to support @import
d0f6b9b
@dckc
build: prune agoric cli (WIP)
e6a6b54 
goal: use https://github.com/Agoric/dapp-agoric-basics/blob/main/contract/scripts/deploy-contract.js
@dckc
build: pin xsnap etc.
a836f08 
build just 1 xsnap, and don't clone the whole git history
@dckc
refactor(test-airdrop): address static type errors
e352e6d
@dckc
style: lint
b2d1248
@dckc
fix: update a3p image tag from main to latest
d1540cc 
cf. Agoric/agoric-3-proposals@1fb8e54
@dckc
fix: don't strip brand
c7a40bd
@dckc
fix: avoid collision between types.js and types.d.ts
b6a658c
@dckc
fix: bring ERTP, Zoe/ZCF types in scope
759683b
@dckc
test: update test-bundle-source to use airdropCampaign
e4320cb
@dckc
refactor: well-typed objectTools (WIP)
df829d1 
why 2 objectTools?

getWindowLength and getTokenQuantity are not generic object tools;
they're specific to EpochDetails; why are they here?
@dckc
build: get ERTP from upgrade-14 (WIP)
ce8b1ff 
is this needed? it's probably best
@dckc
fix: export privateArgsShape, customTermsShape for compat.
62a148d
@dckc
refactor: static types for airdrop/prepare
5bab13d
@dckc
refactor: use TimestampRecord in updateEpochDetails
ab28503
@dckc
fix: currentCancelToken typo (WIP NEEDSTEST)
5fe69a0
@dckc
refactor: 86_400n -> DAY
50150f0 
we have constants for stuff like ONE_THOUSAND where the
literal is at least as clear, but not for 86_400n?
(is that 1 day? 10 days?)
@dckc
refactor: harden() consistently
7feff8d
@dckc
refactor: misc test notes
f9a8cfd
@dckc
build: lock packages with typescript @import
73abd0c
@dckc
test: tone down bundle logging
82befce
@dckc
test: skip non-working tests; add todo to empty test file
79729c9
@tgrecojs
feat(timer): **WIP**
8480e4f 
* added logic for using absolute timers.

### To do

- [] remove distribution schedule logic
@tgrecojs
refactor:
1f82951 
1. state machine logic
    * removed values related to constructing state machine from customTerms.

2. streamlined airdrop preparation
    * removed  from exo object.
    * moved logic responsible for setting wake up fn that triggers contract state to transition from prepared -> open out of exo object (iow, marks the contract as being open for claim)
@tgrecojs tgrecojs merged commit e3ca4cf into dev Apr 15, 2024
1 check failed
@tgrecojs tgrecojs mentioned this pull request Apr 27, 2024
Closed
@dckc dckc mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgrecojs @dckc