-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Build hitpay app for cal.com #1
Conversation
packages/app-store/hitpay/api/add.ts
Outdated
// import { createDefaultInstallation } from "@calcom/app-store/_utils/installation"; | ||
// import type { AppDeclarativeHandler } from "@calcom/types/AppHandler"; | ||
// import appConfig from "../config.json"; | ||
// const handler: AppDeclarativeHandler = { | ||
// appType: appConfig.type, | ||
// variant: appConfig.variant, | ||
// slug: appConfig.slug, | ||
// supportsMultipleInstalls: false, | ||
// handlerType: "add", | ||
// createCredential: ({ appType, user, slug, teamId }) => | ||
// createDefaultInstallation({ appType, user: user, slug, key: {}, teamId }), | ||
// }; | ||
// export default handler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MuhammadAimanSulaiman, please remove.
@@ -0,0 +1,39 @@ | |||
// import type { Prisma } from "@prisma/client"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it
@@ -0,0 +1,61 @@ | |||
import type { NextApiRequest, NextApiResponse } from "next"; | |||
// import getRawBody from "raw-body"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it
bookerName: string, | ||
paymentOption: PaymentOption, | ||
bookerEmail: string | ||
// bookerPhoneNumber?: string | null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove unused code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted all unused code
d49034b
to
3671c85
Compare
packages/app-store/hitpay/zod.ts
Outdated
value: z.string(), | ||
}); | ||
|
||
export const paymentOptionsSchema = z.array(paymentOptionSchema); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need paymentOptionsSchema
, please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images are for the description on cal app store.
We shouldn't remove them and should replace them with ones related to hitpay.
saltKey: string | null; | ||
} | ||
|
||
export interface IHitPayWebhookEventReturn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused interface IHitPayWebhookEventReturn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it
import { useEffect } from "react"; | ||
import { z } from "zod"; | ||
|
||
// import type { PaymentPageProps } from "@calcom/features/ee/payments/pages/payment"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it
// Will be parsed on render | ||
data: unknown; | ||
}; | ||
// paymentPageProps: PaymentPageProps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it
|
||
export const HitpayPaymentComponent = (props: IPaymentComponentProps) => { | ||
const { payment } = props; | ||
console.log("HitpayPaymentComponent payment prop =>", payment); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it
import { useLocale } from "@calcom/lib/hooks/useLocale"; | ||
import { Alert, Select, TextField } from "@calcom/ui"; | ||
|
||
import { paymentOptions } from "../lib/constants"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change with import { paymentOptions } from "../lib";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it
const { getAppData, setAppData, disabled } = useAppContextWithSchema<typeof appDataSchema>(); | ||
const { enabled, updateEnabled } = useIsAppEnabled(app); | ||
const otherPaymentAppEnabled = checkForMultiplePaymentApps(eventTypeFormMetadata); | ||
const [requirePayment, setRequirePayment] = useState(getAppData("enabled")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove setRequirePayment
if we don't need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it
684f5ac
to
3bd6e64
Compare
f37c734
to
ccdecba
Compare
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
d625967
to
effe6c5
Compare
calcom#18416) Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
* global-error is not needed * remove /403 and /500 pages from pages router * add 403 and 500 pages in App Router * add i18n strings * fix i18n string * fix styling
…y undetected before) (calcom#18432)
…rocess (calcom#18429) - Introduced a new `DryRunMessage` component to inform users when in dry run mode. - Implemented utility function `isBookingDryRun` to check for dry run status based on URL search parameters. - Updated the `Booker` component to conditionally render the dry run message. - Adjusted booking mutation input mapping to reuse the utility Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
* migrate icons page * migrate main index page * remove /icons page * use i18n string * fix imports * add icons_showcase i18n string * add /app dir to tailwind preset config * use classname * do not migrate main index page
* feat: apply full width automatically for DataTable * change implementation * load all columns of insights routing table at the same time * update team member list * sticky columns for >= sm * fix type error --------- Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
* chore: sync with main * feat: update translations via @replexica --------- Co-authored-by: Replexica <support@replexica.com>
* fix: get bookings ordering * chore: update query * chore: add log for debuggin on prod * chore
…dy in view on mount (calcom#18446)
* fix: Zoho Bigin not pulling information from booking * update * missed * fix contactcreation
* feat: Enhance SCIM user attribute handling and sync process - Introduced a new PR_TODO.md file to track ongoing tasks and fixes. - Updated `getAttributesFromScimPayload` to accept a directoryId and ignore core user attributes during syncing. - Modified `handleUserEvents` to pass directoryId when syncing custom attributes. - Improved attribute creation logic to handle unique options and added support for optional isGroup property in attribute options. - Added utility function `getOptionsWithValidContains` to ensure valid sub-options in attribute options. - Updated tests to reflect changes in attribute handling and ensure proper functionality. This commit addresses issues with user attribute syncing and enhances the overall attribute management process. * test: Add unit tests for getOptionsWithValidContains utility function - Introduced a new test file for the getOptionsWithValidContains function. - Added tests to verify the removal of duplicate options, initialization of empty contains arrays, filtering of non-existent sub-options, and handling of empty options arrays. - Ensured comprehensive coverage of the utility's functionality to enhance reliability and maintainability.
…ore (calcom#18579) Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
* fix: improve filters at /bookings * fix type
* chore: skip failure e2e test * Update .env * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update .env * Update manage-booking-questions.e2e.ts * fix * fix flake * Update saml.e2e.ts
* Update mint.json * fix broken links --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com>
* feat: added pagination to platform managed users table * removed console * implemented feedback, removed unused components * added label * Update managed-users-view.tsx * Update managed-users-view.tsx
Co-authored-by: Replexica <support@replexica.com>
* new granola app * granola app
* fix: wrong Meeting Ended payload in zapier * fix
* Create dub links if valid * Map through filtered links --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
* Fix error * remove indent --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Co-authored-by: Omar López <zomars@me.com>
Co-authored-by: Omar López <zomars@me.com>
* chore: apps/[slug] remove pages router * remove apps/[slug] pages from /future * chore: apps/installed remove pages router * chore: apps/installation remove pages router * remove Head element * fix metadata * fix test * fix another test * chore: apps/categories remove pages router * revert unneeded changes * update middleware * Remove <Head> * remove unused import and code * remove unused import and code again * fix * fix category page * add split icon * add /routing paths to middleware matcher * wip * remove HeadSeo from App.tsx * clean up head-seo test * add generateAppMetadata * use generateAppMetadata in apps/[slug] page * delete file * remove log * fix * fix * fix apps/installed pages * fix cateogires pages * fix * fix imports * wip * fix * fix * fix metadata * fix * redirect /apps/routing-forms to /routing * replace all usages of /apps/routing-forms to /routing * better naming * /routing -> /routing/forms * fix * fix * fix * fix * remove backPath as it is irrelevant when withoutMain is true * fix type checks * fix type check in apps/[slug] * refactors * fix * fix test * fix * fix * fix * Replace multiple leading slashes with a single slash * migrate routing-forms too * add re routing * fix * add redirection --------- Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
* wip * wip * fix not found page * render middleware for /settings pages * fix * remove global-error page * add metadata to not-found page * make not-found page static * remove 404 * adding not-found to middleware is not necessary * add every routes to config.matcher * fix test * fix style * use i18n string * fix tests * fix * fix * revert unneeded changes * fix * fix * fix * fix style * fix * remove 404 * remove log * fix * fix * fix * fix * better naming * parallel testing --------- Co-authored-by: Benny Joo <sldisek783@gmail.com>
…ages/_error` (calcom#18606) * remove page/_error * refactor app/error
…dling (calcom#18615) * fix lint error * fix booking page and better error handling
0ecbfe6
to
45876b5
Compare
Adding hitpay functions to hitpay app