Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding the experience decisioning plugin to handle experiments, audiences and campaigns #31

Merged
merged 18 commits into from
Oct 30, 2023

Conversation

ramboz
Copy link
Collaborator

@ramboz ramboz commented Sep 14, 2023

Replacing the initial experimentation engine with the newer experience decisioning plugin for Franklin.

The plugin is the more mature version of the initial engine and follows the same APIs and authoring experience.
See: https://github.com/adobe/franklin-experience-decisioning/

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

c84235a fix: experiment split metadata parsing

git-subtree-dir: plugins/experience-decisioning
git-subtree-split: c84235a1896d5e8a3be0b1494a12ae7444110e7e
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

5e1c34a fix: audience parsing

git-subtree-dir: plugins/experience-decisioning
git-subtree-split: 5e1c34a37597aae320032adc4224c93eb022c2be
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@iuliag iuliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and comments below are mostly referring to the experience decisioning plugin itself, not on how it's applied to this repo.
But... there's something buggy with the CSS/font that needs to be solved:
experiment-decisioning-overlay

plugins/experience-decisioning/package.json Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
scripts/scripts.js Outdated Show resolved Hide resolved
plugins/experience-decisioning/src/preview.js Outdated Show resolved Hide resolved
plugins/experience-decisioning/src/preview.js Outdated Show resolved Hide resolved
plugins/experience-decisioning/src/index.js Outdated Show resolved Hide resolved
@ramboz
Copy link
Collaborator Author

ramboz commented Oct 3, 2023

@iuliag Yes, the CSS is a bit of a mess… the site styles are leaking quite a bit in the pill. They are a tad too generic.
I went ahead and manually set all CSS props on the pill to limit conflicts, but ideally, we should rewrite as a web component with isolated shadow DOM… but I think that will warrant a full separate PR

1ee2ee2 doc: update readme
c7717e5 chore: minor fixes and rebranding
e2d61a8 chore: minor fixes and rebranding
40977e3 doc: rebranding to aem
80f6997 fix: css load path if prefix is used, and minor css adjustments to pill

git-subtree-dir: plugins/experience-decisioning
git-subtree-split: 1ee2ee2b9d7e999d38c898ec53508bb186cd0dc7
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 3, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

f602282 fix: fix linting issues and style leaks

git-subtree-dir: plugins/experience-decisioning
git-subtree-split: f60228213acf8f11c4ad8ad1384cfbd36d0375c7
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 3, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@ramboz ramboz requested a review from iuliag October 3, 2023 09:32
@ramboz
Copy link
Collaborator Author

ramboz commented Oct 5, 2023

@iuliag let me know if you still have any concerns

be2e07d doc: update README.md
287e35f feat: adopt the plugin api (#2)
9028520 fix: possible css leaking into pill overlay
162aab2 fix: improve anonymization for better gdpr/hippa compliance (#3)
0071dbd fix: audience pill activation
a486023 fix: audience parsing
4789afd feat: limit the sampling rate
7fbef36 feat: limit the sampling rate (#1)
92e2abb fix: campaigns parsing
4467d3e fix: block-level experiments resolution
4438f52 doc: update readme
44a3aa4 fix: support installation in sub-directories
a77433f style: properly inherit text color in the overlay

git-subtree-dir: plugins/experience-decisioning
git-subtree-split: be2e07ddce1d9c8d1622e6221f7a16593d87b811
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@ramboz ramboz merged commit 49c1f7e into main Oct 30, 2023
2 checks passed
@ramboz ramboz deleted the experience-decisioning branch October 30, 2023 07:56
FentPams added a commit that referenced this pull request Jul 24, 2024
f7c45aa fix: Support Flexible Parsing (#37)
f29dd80 fix: failing tests following refactoring
9db77eb fix: audience checkpoint name
7dc74e1 feat: prepare data for RUMv2 collection
f6ccbcd fix: update getAllMetadata function (#33)
ae769a2 feat: Supporting Naming Variants in Page Expereimentation (#31)

git-subtree-dir: plugins/experimentation
git-subtree-split: f7c45aa70429cb111599cd5a257e22a0d336f77e
FentPams added a commit that referenced this pull request Jul 29, 2024
9db8662 feat: support customized variant name for fragment variants (#36)
c9ff2c0 fix: only fetch pathname to fix url matching issue (#38)
f7c45aa fix: Support Flexible Parsing (#37)
f29dd80 fix: failing tests following refactoring
9db77eb fix: audience checkpoint name
7dc74e1 feat: prepare data for RUMv2 collection
f6ccbcd fix: update getAllMetadata function (#33)
ae769a2 feat: Supporting Naming Variants in Page Expereimentation (#31)

git-subtree-dir: plugins/experimentation
git-subtree-split: 9db86622117e4327cec042bfc3b16e73a71a4bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants