Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

bug with del touch (EOL overright) #17

Closed
Esysteme opened this issue May 12, 2014 · 5 comments
Closed

bug with del touch (EOL overright) #17

Esysteme opened this issue May 12, 2014 · 5 comments

Comments

@Esysteme
Copy link

We send some text, and after push del, all char on the right of cursor are overight with the current background.

screenshot009

@Hywan
Copy link
Member

Hywan commented May 12, 2014

Hello :-),

Can you give us a MWE (Minimal Working Example)?

@Esysteme
Copy link
Author

set background color on all screen, set cursor on top and ask readline.

have to make some ansi string, will do it tonight

@Hywan
Copy link
Member

Hywan commented May 14, 2014

This is not a bug from Hoa\Console\Readline. It depends a lot of how you “fill” the background. Can you show me your code please?

@Esysteme
Copy link
Author

lib to make a window : https://github.com/Esysteme/glial/blob/master/Glial/Cli/Window.php

code to make it : (work with composer)

<?php
new \Glial\Cli\Window('Title', "line1\nline2\n[[INPUT]]");

?>

not the last one but enough to understand, all char of screen are set with \Glial\Cli\Color and after I just move cursor to set at the right place

@Hywan
Copy link
Member

Hywan commented Jan 7, 2015

Now we can address this bug :-).

Hywan added a commit to Hywan/Console that referenced this issue Jul 27, 2015
When a character is not printable, the readline did still print it. In
some cases, it could create weird bug (see [1] or [2]). Since we have the
`Hoa\Ustring::isCharPrintable`, we can check whether a character is
printable or not. Consequently, here is the new logic:

  * We read a character,
  * The buffer receives this character,
  * If there is no mapping for this character and if it is not
    printable, then we do not print it. We do nothing with it.

So, if we would like to support a control character that is not
printable, we must associate a mapping to this character (like we do for
`Ctrl-A` for instance).

[1]: hoaproject#16
[2]: hoaproject#17
@Hywan Hywan closed this as completed Jul 27, 2015
@Hywan Hywan removed the in progress label Jul 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants