This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Print character only if printable #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We return earlier to avoid a deep control flow graph. It simplify the next commit.
When a character is not printable, the readline did still print it. In
some cases, it could create weird bug (see [1] or [2]). Since we have the
`Hoa\Ustring::isCharPrintable`, we can check whether a character is
printable or not. Consequently, here is the new logic:
* We read a character,
* The buffer receives this character,
* If there is no mapping for this character and if it is not
printable, then we do not print it. We do nothing with it.
So, if we would like to support a control character that is not
printable, we must associate a mapping to this character (like we do for
`Ctrl-A` for instance).
[1]: hoaproject#16
[2]: hoaproject#17
Previous commit avoids to print a non-printable character. This one just add a “bell”/“bip” when the user did press such a character. This is a sonor indication that something wrong happened.
|
Previous commit avoids to print a non-printable character. This one just add a “bell”/“bip” when the user did press such a character. This is a sonor indication that something wrong happened. |
|
Asking a review from @hoaproject/hoackers :-). |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16 and #17.
When a character is not printable, the readline did still print it. In some cases, it could create weird bug (see 1 or 2). Since we have the
Hoa\Ustring::isCharPrintable, we can check whether a character is printable or not. Consequently, here is the new logic:So, if we would like to support a control character that is not printable, we must associate a mapping to this character (like we do for
Ctrl-Afor instance).