refactor: cli module #317
Merged
refactor: cli module #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthme
requested changes
Jul 3, 2024
matthme
approved these changes
Jul 4, 2024
c12i
removed
the
ShouldBackport/0.3
c12i
added a commit
to c12i/scaffolding
that referenced
this pull request
Jul 17, 2024
* refactor: cli module to command submodules * add missing doc strings * fix clippy warnings * update cli/zome.rs * inline some functions * set package manager explicitly on holo integration scripts * limit inlined functions * implement FromStr for FieldDefinition * refactor scaffold/app/cargo.rs * update entry_type/crud.rs * fix clippy warnings * add removed fast track config * fix clippy warnings * prefer if else to pattern matching on boolean expressions where possible * move warning missage to scaffold_entry_type * remove template arg
c12i
added a commit
that referenced
this pull request
Jul 18, 2024
* feat: make scaffolding cli package manager agnostic (#316) * add package manager module * add test cases * add bun support * refactor test filetree to resemble actual hApp filetree * update setup_git_environment * add package manager command handlebars helper * add test cases for package_manager_command helper * use package_manager_command helper * update ui package.json templates * replace random port package * set pnpm install command to recursive * add corepack_20 package to include required packages * fix test_run_with_pnpm test * add bun to packages * add short version for package_manager flag * use pnpm on tests * update hello world example ui script * update template readme * revert to npm * add mising version field in tests/package.json * update rimraf * fix hello world template * remove unnecessary depdencencies from vanilla template * add missing rimraf dependency * add missing package_manager field to example hbs context data * add cli docs * update lib.rs docs * fix failing doc tests * limit package manager option to specific commands that only need it * update docs * Setting up nix is optional for example apps (#138) * Setting up nix is optional * refactor nix set up --------- Co-authored-by: Collins Muriuki <hello@collinsmuriuki.xyz> * feat: replace command with git2 * refactor: clean up duplicated templates (#313) * derive common templates * derive a scaffold config module and move config related code to it * remove field types from generic templates * delete repeated templates * fix clippy warnings * further trim down repeated templates * feat: make scaffolding cli package manager agnostic (#316) * add package manager module * add test cases * add bun support * refactor test filetree to resemble actual hApp filetree * update setup_git_environment * add package manager command handlebars helper * add test cases for package_manager_command helper * use package_manager_command helper * update ui package.json templates * replace random port package * set pnpm install command to recursive * add corepack_20 package to include required packages * fix test_run_with_pnpm test * add bun to packages * add short version for package_manager flag * use pnpm on tests * update hello world example ui script * update template readme * revert to npm * add mising version field in tests/package.json * update rimraf * fix hello world template * remove unnecessary depdencencies from vanilla template * add missing rimraf dependency * add missing package_manager field to example hbs context data * add cli docs * update lib.rs docs * fix failing doc tests * limit package manager option to specific commands that only need it * update docs * fix dprint dependency and hds test script * refactor: cli module (#317) * refactor: cli module to command submodules * add missing doc strings * fix clippy warnings * update cli/zome.rs * inline some functions * set package manager explicitly on holo integration scripts * limit inlined functions * implement FromStr for FieldDefinition * refactor scaffold/app/cargo.rs * update entry_type/crud.rs * fix clippy warnings * add removed fast track config * fix clippy warnings * prefer if else to pattern matching on boolean expressions where possible * move warning missage to scaffold_entry_type * remove template arg * Update git2 dependency features (#326) * ci: update git2 dependency features * Tweak features for git2 --------- Co-authored-by: Collins Muriuki <hello@collinsmuriuki.xyz> * feat: programatically format generated svelte and vue markup (#333) * feat: programatically format generated svelte and vue markup * refactor format code function * refactor format_nested and vue example templates * fix clippy warnings * return Cow from format_nested * fix inline jsx/tsx expressions not getting formatted * update vue template * fix vue templates * fix: Missing dependency with lit template using `pnpm` (#334) * fix: add missing tslib dependency on lit template * use pnpm in ci * use parameterized package manager in ci wf template * fix misplaced fix * bump version * fix clippy warnings * add postinstall script for pnpm scaffolded hApps (#338) * nix flake update --------- Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
cli.rsmodule by extracting each subcommand into its own submodule for improved maintainability and modularity