Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add postinstall script for pnpm scaffolded hApps #338

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Jul 17, 2024

fixes #324

@c12i c12i added the ShouldBackport/0.3 This change should be backported to develop-0.3 label Jul 17, 2024
@c12i c12i requested a review from matthme July 17, 2024 14:54
@c12i c12i marked this pull request as ready for review July 17, 2024 14:54
Copy link
Collaborator

@matthme matthme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@c12i c12i merged commit c914ea2 into holochain:develop Jul 18, 2024
8 checks passed
c12i added a commit to c12i/scaffolding that referenced this pull request Jul 18, 2024
c12i added a commit that referenced this pull request Jul 18, 2024
* feat: make scaffolding cli package manager agnostic (#316)

* add package manager module

* add test cases

* add bun support

* refactor test filetree to resemble actual hApp filetree

* update setup_git_environment

* add package manager command handlebars helper

* add test cases for package_manager_command helper

* use package_manager_command helper

* update ui package.json templates

* replace random port package

* set pnpm install command to recursive

* add corepack_20 package to include required packages

* fix test_run_with_pnpm test

* add bun to packages

* add short version for package_manager flag

* use pnpm on tests

* update hello world example ui script

* update template readme

* revert to npm

* add mising version field in tests/package.json

* update rimraf

* fix hello world template

* remove unnecessary depdencencies from vanilla template

* add missing rimraf dependency

* add missing package_manager field to example hbs context data

* add cli docs

* update lib.rs docs

* fix failing doc tests

* limit package manager option to specific commands that only need it

* update docs

* Setting up nix is optional for example apps (#138)

* Setting up nix is optional

* refactor nix set up

---------

Co-authored-by: Collins Muriuki <hello@collinsmuriuki.xyz>

* feat: replace command with git2

* refactor: clean up duplicated templates (#313)

* derive common templates

* derive a scaffold config module and move config related code to it

* remove field types from generic templates

* delete repeated templates

* fix clippy warnings

* further trim down repeated templates

* feat: make scaffolding cli package manager agnostic (#316)

* add package manager module

* add test cases

* add bun support

* refactor test filetree to resemble actual hApp filetree

* update setup_git_environment

* add package manager command handlebars helper

* add test cases for package_manager_command helper

* use package_manager_command helper

* update ui package.json templates

* replace random port package

* set pnpm install command to recursive

* add corepack_20 package to include required packages

* fix test_run_with_pnpm test

* add bun to packages

* add short version for package_manager flag

* use pnpm on tests

* update hello world example ui script

* update template readme

* revert to npm

* add mising version field in tests/package.json

* update rimraf

* fix hello world template

* remove unnecessary depdencencies from vanilla template

* add missing rimraf dependency

* add missing package_manager field to example hbs context data

* add cli docs

* update lib.rs docs

* fix failing doc tests

* limit package manager option to specific commands that only need it

* update docs

* fix dprint dependency and hds test script

* refactor: cli module (#317)

* refactor: cli module to command submodules

* add missing doc strings

* fix clippy warnings

* update cli/zome.rs

* inline some functions

* set package manager explicitly on holo integration scripts

* limit inlined functions

* implement FromStr for FieldDefinition

* refactor scaffold/app/cargo.rs

* update entry_type/crud.rs

* fix clippy warnings

* add removed fast track config

* fix clippy warnings

* prefer if else to pattern matching on boolean expressions where possible

* move warning missage to scaffold_entry_type

* remove template arg

* Update git2 dependency features (#326)

* ci: update git2 dependency features

* Tweak features for git2

---------

Co-authored-by: Collins Muriuki <hello@collinsmuriuki.xyz>

* feat: programatically format generated svelte and vue markup (#333)

* feat: programatically format generated svelte and vue markup

* refactor format code function

* refactor format_nested and vue example templates

* fix clippy warnings

* return Cow from format_nested

* fix inline jsx/tsx expressions not getting formatted

* update vue template

* fix vue templates

* fix: Missing dependency with lit template using `pnpm` (#334)

* fix: add missing tslib dependency on lit template

* use pnpm in ci

* use parameterized package manager in ci wf template

* fix misplaced fix

* bump version

* fix clippy warnings

* add postinstall script for pnpm scaffolded hApps (#338)

* nix flake update

---------

Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com>
c12i added a commit to c12i/scaffolding that referenced this pull request Jul 30, 2024
@c12i c12i removed the ShouldBackport/0.3 This change should be backported to develop-0.3 label Jul 30, 2024
c12i added a commit that referenced this pull request Jul 31, 2024
* fix URL warnings

* bump versions

* fix: use pnpm workspace yaml file with pnpm happs (#340)

* add postinstall script for pnpm scaffolded hApps (#338)

* fix clippy warnings

* nix flake update

* update ci dependencies

* Use latest Nix (#329)

* Use latest Nix

* Update template workflows

* Flakes enabled by default

* bump to 0.3.2

* bump crate version; nix flake update

* use 0_3_rc

---------

Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: sporadic bug when starting hApp with hc-spin via pnpm
2 participants