Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional title and update nyc_buildings #251

Closed
wants to merge 7 commits into from
Closed

Conversation

maximlt
Copy link
Contributor

@maximlt maximlt commented Jan 24, 2023

This PR adds the possibility to define a title for a project when the prettified project name is not satisfying, e.g. Nyc Buildings instead of the preferred NYC Buildings.

It also updates nyc_buildings as an example usage of this new functionality.

I've built the docs locally and saw a couple of annoying issues.

  • The docs are rendered with all the intermediate states of the ProgressBar.
    image

Not sure where this problem comes from. We could work around it by simply removing the ProgressBar but it would at least be good to identify where it's from. It might be from executablebooks/MyST-NB#440 (that was fixing displaying HoloViews objects in mystnb 🙃 )

myst-nb                   0.17.1                   pypi_0    pypi
myst-parser               0.18.1                   pypi_0    pypi
pydata-sphinx-theme       0.9.0              pyhd8ed1ab_1    conda-forge
sphinx                    5.3.0                    pypi_0    pypi
  • There are many of this warning that I didn't see in the notebook while running it:
/Users/mliquet/work/dev/examples/nyc_buildings/envs/default/lib/python3.9/site-packages/holoviews/operation/datashader.py:1482: UserWarning: rename 'x' to 'x' does not create an index anymore. Try using swap_dims instead or use set_index after rename to create an indexed coordinate.
  agg = agg.rename({'x': xdim.name, 'y': ydim.name})
/Users/mliquet/work/dev/examples/nyc_buildings/envs/default/lib/python3.9/site-packages/holoviews/operation/datashader.py:1482: UserWarning: rename 'y' to 'y' does not create an index anymore. Try using swap_dims instead or use set_index after rename to create an indexed coordinate.
  agg = agg.rename({'x': xdim.name, 'y': ydim.name})

It seems to me these warnings were removed in holoviz/holoviews#5470 and that the env I used to build the notebook had the latest version of HoloViews (1.15.4). Not sure where they're coming from.

  • And the tests failed, while they ran fine on my Mac, with an error raised from SpatialPandas:
 File ~/work/examples/examples/nyc_buildings/envs/test/lib/python3.9/site-packages/spatialpandas/io/parquet.py:350, in _perform_read_parquet_dask(paths, columns, filesystem, load_divisions, geometry, bounds, categories, storage_options, engine_kwargs)
    347 pieces = []
    348 for dataset in datasets:
    349     # Perform natural sort on pieces so that "part.10" comes after "part.2"
--> 350     dataset_pieces = sorted(dataset.fragments, key=lambda piece: natural_sort_key(piece.path))
    351     pieces.extend(dataset_pieces)
    353 delayed_partitions = [
    354     delayed(read_parquet)(
    355         piece.path,
   (...)
    361     for piece in pieces
    362 ]

AttributeError: '_ParquetDatasetV2' object has no attribute 'fragments'

@maximlt maximlt mentioned this pull request Jan 29, 2023
@maximlt
Copy link
Contributor Author

maximlt commented Nov 2, 2023

Superseded by #322

@maximlt maximlt closed this Nov 2, 2023
@maximlt maximlt deleted the add_optional_title branch October 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant