-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings #5470
Fix warnings #5470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5470 +/- ##
==========================================
- Coverage 88.13% 88.09% -0.04%
==========================================
Files 302 302
Lines 62225 62262 +37
==========================================
+ Hits 54842 54851 +9
- Misses 7383 7411 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
14ddeae
to
ddff63c
Compare
Just to say I went through this commit by commit with @hoxbro and I'm happy with everything except a few things that Simon has noted on my behalf. |
@philippjfr, can you take a look at two of the changes when you have time? Changed rename to swap_dims for xarray Note: I'm pretty sure there is no problem related to this one. I just want to be sure. UserWarning: rename 'x' to 'x' does not create an index anymore. Try using swap_dims instead or use set_index after rename to create an indexed coordinate. Use ax.remove in _compute_gridspec Note: This is more obscure, and I can be wrong here. If you are unsure, I can remove the commit from this PR and create a new PR solely focused on this commit. The warning related to this is: /home/shh/Development/holoviz/repos/holoviews/holoviews/plotting/mpl/plot.py:947: MatplotlibDeprecationWarning: Auto-removal of overlapping axes is deprecated since 3.6 and will be removed two minor releases later; explicitly call ax.remove() as needed.
subaxes = [plt.subplot(self.gs[ind], projection=proj) |
I have removed the fixes for the warning with uncertainties, so this should be ready to be merged now. The removed fixes can be done in a future PR. |
Went through these with @hoxbro and these are all very helpful updates! Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Working through the backlogs of warnings from the test suite.
Warnings after
It needs to be fixed by plotly upstream: plotly/plotly.py#3897
It depends on the future of spatialpandas.
Related to Datashader (@ianthomas23 is aware of it)
holoviews/tests/plotting/bokeh/test_server.py::TestBokehServer::test_launch_server_with_complex_plot /home/shh/miniconda3/envs/holoviz/lib/python3.9/site-packages/tornado/ioloop.py:350: DeprecationWarning: make_current is deprecated; start the event loop first self.make_current() holoviews/tests/plotting/bokeh/test_server.py::TestBokehServer::test_launch_server_with_complex_plot holoviews/tests/plotting/bokeh/test_server.py::TestBokehServer::test_launch_server_with_stream holoviews/tests/plotting/bokeh/test_server.py::TestBokehServer::test_launch_simple_server holoviews/tests/plotting/bokeh/test_server.py::TestBokehServer::test_server_dynamicmap_with_dims holoviews/tests/plotting/bokeh/test_server.py::TestBokehServer::test_server_dynamicmap_with_stream holoviews/tests/plotting/bokeh/test_server.py::TestBokehServer::test_server_dynamicmap_with_stream_dims /home/shh/Development/holoviz/repos/panel/panel/io/server.py:880: DeprecationWarning: make_current is deprecated; start the event loop first loop.make_current()
A panel problem: holoviz/panel#3885
Warnings before