Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop requirement for NdMapping to be defined with OrderedDict #5867

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

philippjfr
Copy link
Member

Since Python dict is now ordered the limitation around requiring an NdMapping input dict to be an OrderedDict is no longer necessary.

@philippjfr philippjfr marked this pull request as ready for review August 28, 2023 09:47
@hoxbro
Copy link
Member

hoxbro commented Aug 28, 2023

Can you also remove?

if type(data) == dict:
raise ValueError("ItemTable cannot accept a standard Python dictionary "
"as a well-defined item ordering is required.")

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #5867 (2d4a7d8) into main (04d7fa6) will increase coverage by 0.13%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #5867      +/-   ##
==========================================
+ Coverage   88.23%   88.36%   +0.13%     
==========================================
  Files         310      310              
  Lines       63962    63959       -3     
==========================================
+ Hits        56434    56517      +83     
+ Misses       7528     7442      -86     
Flag Coverage Δ
ui-tests 23.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/core/ndmapping.py 80.03% <ø> (+0.11%) ⬆️
holoviews/element/tabular.py 50.79% <50.00%> (-0.77%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit e3dee54 into main Aug 28, 2023
13 of 14 checks passed
@hoxbro hoxbro deleted the ndmapping_ordered_dict_limitation branch August 28, 2023 20:40
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants