Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop requirement for NdMapping to be defined with OrderedDict #5867

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Drop requirement for NdMapping to be defined with OrderedDict #5867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76a69e
Drop requirement for NdMapping to be defined with OrderedDict
philippjfr Aug 28, 2023
2d4a7d8
Also fix tabular
hoxbro Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions holoviews/core/ndmapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,6 @@ def __init__(self, initial_items=None, kdims=None, **params):
if kdims is not None:
params['kdims'] = kdims
super().__init__(OrderedDict(), **dict(params))
if type(initial_items) is dict and not self.sort:
raise ValueError('If sort=False the data must define a fixed '
'ordering, please supply a list of items or '
'an OrderedDict, not a regular dictionary.')

self._next_ind = 0
self._check_key_type = True
Expand Down
6 changes: 2 additions & 4 deletions holoviews/element/tabular.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,8 @@ def cols(self):
def __init__(self, data, **params):
if data is None:
data = []
if type(data) == dict:
raise ValueError("ItemTable cannot accept a standard Python dictionary "
"as a well-defined item ordering is required.")
elif isinstance(data, dict): pass
if isinstance(data, dict):
pass
elif isinstance(data, list):
data = OrderedDict(data)
else:
Expand Down
Loading