-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve following behavior when streaming #6318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backtracking behavior was fixed in holoviz/panel#7128 |
hoxbro
added
the
type: enhancement
Minor feature or improvement to an existing feature
label
Aug 16, 2024
philippjfr
force-pushed
the
stream_following
branch
from
September 25, 2024 08:14
9c682b5
to
c11808f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6318 +/- ##
==========================================
- Coverage 88.49% 88.48% -0.02%
==========================================
Files 323 323
Lines 68304 68431 +127
==========================================
+ Hits 60448 60550 +102
- Misses 7856 7881 +25 ☔ View full report in Codecov by Sentry. |
hoxbro
approved these changes
Sep 26, 2024
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There still appears to be a race condition in bokeh where if a stream event arrives while the frontend is rendering it can cause "backtracking" glitches.TODO:
Code