Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure events are dispatched sequentially #7128

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Ensure events are dispatched sequentially #7128

merged 3 commits into from
Aug 11, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6603

Supersedes #7115

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 10.20408% with 44 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (9404b43) to head (57a0b1b).
Report is 2 commits behind head on main.

Files Patch % Lines
panel/io/document.py 10.20% 44 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9404b43) and HEAD (57a0b1b). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (9404b43) HEAD (57a0b1b)
8 6
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7128      +/-   ##
==========================================
- Coverage   82.25%   72.38%   -9.87%     
==========================================
  Files         327      326       -1     
  Lines       48784    48824      +40     
==========================================
- Hits        40127    35343    -4784     
- Misses       8657    13481    +4824     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member Author

Test failures seem unrelated. Will look at making a PR to fix tests next.

@philippjfr philippjfr merged commit 752626d into main Aug 11, 2024
12 of 16 checks passed
@philippjfr philippjfr deleted the 6603_fix branch August 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sneaky Race condition using asyncio create_task (reliably reproduced)
1 participant