Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not propagate clicks on input elements in Card header #7057

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

philippjfr
Copy link
Member

Fixes #7045

panel/models/card.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (7c90f7b) to head (af9fa5c).
Report is 2 commits behind head on main.

Files Patch % Lines
panel/tests/ui/layout/test_card.py 0.00% 13 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7c90f7b) and HEAD (af9fa5c). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (7c90f7b) HEAD (af9fa5c)
8 5
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7057      +/-   ##
==========================================
- Coverage   81.79%   72.48%   -9.31%     
==========================================
  Files         326      325       -1     
  Lines       48350    48393      +43     
==========================================
- Hits        39546    35079    -4467     
- Misses       8804    13314    +4510     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 071f51a into main Aug 2, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the card_input_do_not_propagate_click branch August 2, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to stop event propagation from a TextInput to a Card header?
1 participant