Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not propagate clicks on input elements in Card header #7057

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Do not propagate clicks on input elements in Card header #7057

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca2a32c
Do not propagate clicks on input elements in Card header
philippjfr Aug 2, 2024
b267a41
Update card.ts
philippjfr Aug 2, 2024
af9fa5c
Apply suggestions from code review
philippjfr Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions panel/models/card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ export class CardView extends ColumnView {
this.button_el.style.backgroundColor = header_background != null ? header_background : ""
header.el.style.backgroundColor = header_background != null ? header_background : ""
this.button_el.appendChild(header.el)

this.button_el.onclick = () => this._toggle_button()
this.button_el.addEventListener("click", (e: MouseEvent) => this._toggle_button(e))
header_el = this.button_el
} else {
header_el = DOM.create_element((header_tag as any), {class: header_css_classes})
Expand Down Expand Up @@ -120,7 +119,12 @@ export class CardView extends ColumnView {
this.invalidate_layout()
}

_toggle_button(): void {
_toggle_button(e: MouseEvent): void {
for (const path of e.composedPath()) {
if (path instanceof HTMLInputElement ) {
philippjfr marked this conversation as resolved.
Show resolved Hide resolved
return
}
}
this.model.collapsed = !this.model.collapsed
}

Expand Down
23 changes: 21 additions & 2 deletions panel/tests/ui/layout/test_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

from playwright.sync_api import expect

from panel import Card
from panel.tests.util import serve_component
from panel import Card, Row
from panel.tests.util import serve_component, wait_until
from panel.widgets import FloatSlider, TextInput

pytestmark = pytest.mark.ui
Expand Down Expand Up @@ -182,3 +182,22 @@ def test_card_scrollable(page):
serve_component(page, card)

expect(page.locator('.card')).to_have_class('bk-panel-models-layout-Card card scrollable-vertical')


def test_card_widget_not_collapsed(page, card_components):
# Fixes https://github.com/holoviz/panel/issues/7045
w1, w2 = card_components
card = Card(w1, header=Row(w2))

serve_component(page, card)

text_input = page.locator('.bk-input[type="text"]')
expect(text_input).to_have_count(1)

text_input.click()

text_input.press("F")
text_input.press("Enter")

wait_until(lambda: w2.value == 'F', page)
assert not card.collapsed
Loading