Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More intuitive error when lsuffix == rsuffix on sjoin #35

Closed
Adam-D-Lewis opened this issue Jun 15, 2020 · 4 comments
Closed

More intuitive error when lsuffix == rsuffix on sjoin #35

Adam-D-Lewis opened this issue Jun 15, 2020 · 4 comments
Milestone
v0.3.5

Comments

@Adam-D-Lewis
Copy link

Right now, callling joined = spd.sjoin(sddf, sdf, how='inner', lsuffix='leftsuffix', rsuffix='rightsuffix') results in RecursionError: maximum recursion depth exceeded while calling a Python object.

It'd be nice to have a Exception message saying something like "lsuffix and rsuffix must not be equal"
@jbednar
Copy link
Member

jbednar commented Jun 15, 2020

Sure! PR gratefully accepted, if you're able!

@Adam-D-Lewis
Copy link
Author

I can't commit to making the PR right now, but I wanted to at least get this documented for others. This would probably make a good first issue if someone is looking to contribute.

brl0 added a commit to Quansight/spatialpandas that referenced this issue Jul 12, 2020
@brl0
Fix holoviz#35
b4f85ee
@brl0 brl0 mentioned this issue Jul 12, 2020
Merged
@jbednar jbednar added this to the v0.3.5 milestone Jul 16, 2020
jbednar pushed a commit that referenced this issue Jul 26, 2020
@brl0
Minor fixes (#37)
550ccf9 
* Fix #34, #35, #36
* Try/except for new numba import
* Modify test_parquet to use str rather than Path
* Fix collections.abc warning
* mkdir for tempdir, reduce retry wait for test
* Skip unsupported pandas extension tests
* Pin pyarrow, update changelog
@brl0
Copy link
Collaborator

brl0 commented Jul 27, 2020

This was addressed in #37 and can probably be closed now.

@Adam-D-Lewis
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.5
Development

No branches or pull requests
3 participants
@jbednar @Adam-D-Lewis @brl0