Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #37

Merged
merged 10 commits into from
Jul 26, 2020
Merged

Minor fixes #37

merged 10 commits into from
Jul 26, 2020

Conversation

brl0
Copy link
Collaborator

@brl0 brl0 commented Jul 12, 2020

Closes #34, #35, #36

If possible, and if this is accepted, it would be helpful to cut a new release once merged.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me!

@jbednar
Copy link
Member

jbednar commented Jul 16, 2020

I'm happy to merge once the tests pass, but on first glance I can't see what those test failures are about. Probably unrelated to this PR, but still seem like they need addressing.

@tylerpotts
Copy link

@jbednar Would it be possible to merge this anyways and cut a release despite the tests failing? We rely on one of the bug fixes in this PR and currently are pip installing from the git hash

@brl0
Copy link
Collaborator Author

brl0 commented Jul 26, 2020

Fixes #41 and #42, along with a couple of other minor issues. All tests should be passing now.

@brl0 brl0 requested a review from jbednar July 26, 2020 19:59
@jbednar jbednar merged commit 550ccf9 into holoviz:master Jul 26, 2020
@jbednar
Copy link
Member

jbednar commented Jul 26, 2020

Thanks so much! I'll tag a dev release.

@jbednar
Copy link
Member

jbednar commented Jul 26, 2020

Tagged: https://github.com/holoviz/spatialpandas/releases/tag/v0.3.5a0

For our other projects, tagging is all that's required for making a release, with the release process automated on Travis. It looks like none of that has been set up on this library yet, so I don't actually know what the process is for making pip and conda packages appear for spatialpandas. @jlstevens, any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_parquet_dask fails to read from s3 glob
3 participants