-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumb python-homewizard-energy to 4.2.1 #108738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you notice that there is still a print statement?
async def data(self) -> Data:
"""Return the data object."""
response = await self.request("api/v1/data")
print(response)
return Data.from_dict(response)
Not that you will get a bug report for shitting the logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems some sensor are added, so does the documentation need an update?
Damn, though I removed that one already 🤦
Not yet, diagnostics show them automatically but the sensor itself is not added. That will be done a follow-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @DCSBL 👍
This version is hard pinning aiohttp to 3.9.1 |
Proposed change
Bumb python-homewizard-energy to prepare for new sensors
https://github.com/homewizard/python-homewizard-energy/releases/tag/v4.2.0
https://github.com/homewizard/python-homewizard-energy/releases/tag/v4.2.1
https://github.com/homewizard/python-homewizard-energy/releases/tag/v4.1.1
homewizard/python-homewizard-energy@v4.1.0...v4.2.1
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: