Bump aiohttp to 3.9.3 #109025

bdraco · 2024-01-28T22:17:27Z

~~needs https://github.com/aio-libs/aiohttp/actions/runs/7701265001~~

Proposed change

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.3

resolves GHSA-5h86-8mv2-jq9f
resolves GHSA-8qpw-xqxj-h4r2

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.2

bdraco · 2024-01-28T22:23:22Z

@DCSBL Can you loosen the dep on python-homewizard-energy to aiohttp>=3.9.1 and release a new version? This is blocking us from upgrading and we need to do so urgently because this is a security release.

#108738

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.2 opened directly to rc since #109025 is blocked

joostlek · 2024-01-28T22:32:00Z

homewizard/python-homewizard-energy#322

bdraco · 2024-01-28T22:34:15Z

Thanks @joostlek

DCSBL · 2024-01-29T06:31:27Z

Seen and started merge + bumb, sorry for inconvenience

DCSBL · 2024-01-29T06:53:08Z

New version is ready without the pinning, thanks for the heads-up both!

#109038

bdraco · 2024-01-29T07:12:04Z

Thanks

joostlek

Tests are failing

home-assistant · 2024-01-29T09:18:36Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

bdraco · 2024-01-29T17:15:35Z

We need to hold on this for another release since 3.9.2 is not compatible with aiobotocore aio-libs/aiohttp#8098

bdraco · 2024-01-29T17:16:36Z

I'll double check the websocket changes but I think this is OK as it's actually being closed instead of getting close and than hanging open now which is a good thing

bdraco · 2024-01-29T17:43:15Z

Final analysis indicates HA is not affected by the two security changes in aiohttp so we can wait for aiobotocore to be fixed here. I'm going to drop the milestone. I'll retarget it as soon as the new aiohttp release is available

bdraco · 2024-01-29T19:42:30Z

https://github.com/aio-libs/aiohttp/actions/runs/7701265001 is cooking now

tested were adjusted

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

…to v2024.1.6 (#350) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.5` -> `2024.1.6` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary> ### [`v2024.1.6`](https://github.com/home-assistant/core/releases/tag/2024.1.6) [Compare Source](home-assistant/core@2024.1.5...2024.1.6) - Pass default SSLContext instances to Octoprint custom HTTP sessions ([@vexofp] - [#105351]) ([octoprint docs]) - Reduce overhead for google calendar state updates ([@allenporter] - [#108133]) ([google docs]) - Fix SleepIQ setting FootWarmer timer ([@jmwaldrip] - [#108433]) ([sleepiq docs]) - Fix zha illuminance measured value mapping ([@floriankisser] - [#108547]) ([zha docs]) - Bump yolink-api to 0.3.6 fix aiomqtt breaking changes ([@matrixd2] - [#108555]) ([yolink docs]) (dependency) - Update openerz-api to 0.3.0 ([@misialq] - [#108575]) ([openerz docs]) (dependency) - Bump aiovodafone to 0.5.4 ([@chemelli74] - [#108592]) ([vodafone_station docs]) (dependency) - Bump airthings-ble to 0.6.0 ([@LaStrada] - [#108612]) ([airthings_ble docs]) (dependency) - Fix alexa fails reporting the state in specific cases ([@jbouwh] - [#108743]) ([alexa docs]) - Reduce log level of ZHA endpoint handler init ([@puddly] - [#108749]) ([zha docs]) - Fix google_assistant climate modes might be None ([@jbouwh] - [#108793]) ([google_assistant docs]) - Fix unhandled exception on humidifier intent when available_modes is None ([@jbouwh] - [#108802]) ([humidifier docs]) - Fix processing supported color modes for emulated_hue ([@jbouwh] - [#108803]) ([emulated_hue docs]) - Reduce log level for creating ZHA cluster handler ([@TheJulianJES] - [#108809]) ([zha docs]) - Fix stalls in config flow of APCUPSD ([@yuxincs] - [#108931]) ([apcupsd docs]) - Add strings to Sensirion BLE ([@joostlek] - [#109001]) ([sensirion_ble docs]) - Fix entity naming for heatpump heatings in ViCare ([@CFenner] - [#109013]) ([vicare docs]) - Bump aiohttp to 3.9.3 ([@bdraco] - [#109025]) (dependency) - Bump ZHA dependency zigpy to 0.60.7 ([@puddly] - [#109082]) ([zha docs]) (dependency) - Add missing abort message for Spotify ([@joostlek] - [#109102]) ([spotify docs]) [#105351]: home-assistant/core#105351 [#106970]: home-assistant/core#106970 [#107239]: home-assistant/core#107239 [#107365]: home-assistant/core#107365 [#107883]: home-assistant/core#107883 [#108133]: home-assistant/core#108133 [#108379]: home-assistant/core#108379 [#108433]: home-assistant/core#108433 [#108502]: home-assistant/core#108502 [#108547]: home-assistant/core#108547 [#108555]: home-assistant/core#108555 [#108575]: home-assistant/core#108575 [#108592]: home-assistant/core#108592 [#108612]: home-assistant/core#108612 [#108743]: home-assistant/core#108743 [#108749]: home-assistant/core#108749 [#108793]: home-assistant/core#108793 [#108802]: home-assistant/core#108802 [#108803]: home-assistant/core#108803 [#108809]: home-assistant/core#108809 [#108931]: home-assistant/core#108931 [#109001]: home-assistant/core#109001 [#109013]: home-assistant/core#109013 [#109025]: home-assistant/core#109025 [#109082]: home-assistant/core#109082 [#109102]: home-assistant/core#109102 [@CFenner]: https://github.com/CFenner [@LaStrada]: https://github.com/LaStrada [@TheJulianJES]: https://github.com/TheJulianJES [@allenporter]: https://github.com/allenporter [@bdraco]: https://github.com/bdraco [@chemelli74]: https://github.com/chemelli74 [@floriankisser]: https://github.com/floriankisser [@frenck]: https://github.com/frenck [@jbouwh]: https://github.com/jbouwh [@jmwaldrip]: https://github.com/jmwaldrip [@joostlek]: https://github.com/joostlek [@matrixd2]: https://github.com/matrixd2 [@misialq]: https://github.com/misialq [@puddly]: https://github.com/puddly [@vexofp]: https://github.com/vexofp [@yuxincs]: https://github.com/yuxincs [airthings_ble docs]: https://www.home-assistant.io/integrations/airthings_ble/ [alexa docs]: https://www.home-assistant.io/integrations/alexa/ [apcupsd docs]: https://www.home-assistant.io/integrations/apcupsd/ [dlna_dmr docs]: https://www.home-assistant.io/integrations/dlna_dmr/ [dlna_dms docs]: https://www.home-assistant.io/integrations/dlna_dms/ [emulated_hue docs]: https://www.home-assistant.io/integrations/emulated_hue/ [enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/ [google docs]: https://www.home-assistant.io/integrations/google/ [google_assistant docs]: https://www.home-assistant.io/integrations/google_assistant/ [humidifier docs]: https://www.home-assistant.io/integrations/humidifier/ [octoprint docs]: https://www.home-assistant.io/integrations/octoprint/ [openerz docs]: https://www.home-assistant.io/integrations/openerz/ [samsungtv docs]: https://www.home-assistant.io/integrations/samsungtv/ [sensirion_ble docs]: https://www.home-assistant.io/integrations/sensirion_ble/ [shelly docs]: https://www.home-assistant.io/integrations/shelly/ [sleepiq docs]: https://www.home-assistant.io/integrations/sleepiq/ [spotify docs]: https://www.home-assistant.io/integrations/spotify/ [ssdp docs]: https://www.home-assistant.io/integrations/ssdp/ [streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/ [system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/ [upnp docs]: https://www.home-assistant.io/integrations/upnp/ [vicare docs]: https://www.home-assistant.io/integrations/vicare/ [vodafone_station docs]: https://www.home-assistant.io/integrations/vodafone_station/ [yeelight docs]: https://www.home-assistant.io/integrations/yeelight/ [yolink docs]: https://www.home-assistant.io/integrations/yolink/ [zha docs]: https://www.home-assistant.io/integrations/zha/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/350 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

Bump aiohttp to 3.9.2

28bbe8c

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.2

bdraco added this to the 2024.1.6 milestone Jan 28, 2024

home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Jan 28, 2024

bdraco added a commit that referenced this pull request Jan 28, 2024

Bump aiohttp to 3.9.2

8b59011

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.2 opened directly to rc since #109025 is blocked

bdraco mentioned this pull request Jan 28, 2024

Bump aiohttp to 3.9.2 #109028

Closed

20 tasks

Merge branch 'dev' into aiohttp392

e28b056

bdraco marked this pull request as ready for review January 29, 2024 07:44

bdraco requested a review from a team as a code owner January 29, 2024 07:44

MartinHjelmare approved these changes Jan 29, 2024

View reviewed changes

joostlek previously requested changes Jan 29, 2024

View reviewed changes

home-assistant bot marked this pull request as draft January 29, 2024 09:18

bdraco removed this from the 2024.1.6 milestone Jan 29, 2024

fix close codes since abnormal closures now close the socket correctly

fe9e5a6

bdraco changed the title ~~Bump aiohttp to 3.9.2~~ Bump aiohttp to 3.9.3 Jan 29, 2024

frenck approved these changes Jan 29, 2024

View reviewed changes

.3

f7d7d26

frenck approved these changes Jan 29, 2024

View reviewed changes

bdraco added this to the 2024.1.6 milestone Jan 29, 2024

bdraco marked this pull request as ready for review January 29, 2024 21:42

frenck merged commit 825fed8 into dev Jan 29, 2024
74 checks passed

frenck deleted the aiohttp392 branch January 29, 2024 22:15

Moustachauve pushed a commit to Moustachauve/HA-core that referenced this pull request Jan 30, 2024

Bump aiohttp to 3.9.3 (home-assistant#109025)

7e4f018

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

frenck added the cherry-picked label Jan 30, 2024

frenck pushed a commit that referenced this pull request Jan 30, 2024

Bump aiohttp to 3.9.3 (#109025)

8429a79

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

frenck mentioned this pull request Jan 30, 2024

2024.1.6 #109129

Merged

github-actions bot locked and limited conversation to collaborators Jan 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump aiohttp to 3.9.3 #109025

Bump aiohttp to 3.9.3 #109025

bdraco commented Jan 28, 2024 •

edited

Loading

bdraco commented Jan 28, 2024 •

edited

Loading

joostlek commented Jan 28, 2024

bdraco commented Jan 28, 2024

DCSBL commented Jan 29, 2024

DCSBL commented Jan 29, 2024 •

edited

Loading

bdraco commented Jan 29, 2024

joostlek left a comment

home-assistant bot commented Jan 29, 2024

bdraco commented Jan 29, 2024

bdraco commented Jan 29, 2024

bdraco commented Jan 29, 2024 •

edited

Loading

bdraco commented Jan 29, 2024

Bump aiohttp to 3.9.3 #109025

Bump aiohttp to 3.9.3 #109025

Conversation

bdraco commented Jan 28, 2024 • edited Loading

Proposed change

Type of change

Additional information

Checklist

bdraco commented Jan 28, 2024 • edited Loading

joostlek commented Jan 28, 2024

bdraco commented Jan 28, 2024

DCSBL commented Jan 29, 2024

DCSBL commented Jan 29, 2024 • edited Loading

bdraco commented Jan 29, 2024

joostlek left a comment

Choose a reason for hiding this comment

home-assistant bot commented Jan 29, 2024

bdraco commented Jan 29, 2024

bdraco commented Jan 29, 2024

bdraco commented Jan 29, 2024 • edited Loading

bdraco commented Jan 29, 2024

bdraco commented Jan 28, 2024 •

edited

Loading

bdraco commented Jan 28, 2024 •

edited

Loading

DCSBL commented Jan 29, 2024 •

edited

Loading

bdraco commented Jan 29, 2024 •

edited

Loading