Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default time zone for evohome tests #126679

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Sep 24, 2024

Proposed change

This is a small PR to set the system time zone so that is is the same as that in each test fixture.

The fixtures contain TZ-naive (local) times, so doing this allows direct comparison of dtm strings, but also covers some of the integration's helper APIs.

This PR was split out from #126407.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zxdavb zxdavb changed the title set timezone for evohome tests Set the time zone for evohome tests Sep 24, 2024
@zxdavb zxdavb changed the title Set the time zone for evohome tests Set the default time zone for evohome tests Sep 24, 2024
@zxdavb zxdavb marked this pull request as draft September 24, 2024 20:18
@zxdavb zxdavb marked this pull request as ready for review September 25, 2024 08:41
zxdavb added a commit to zxdavb/hass that referenced this pull request Sep 25, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zxdavb 👍

../Frenck

@frenck frenck merged commit 2d16732 into home-assistant:dev Sep 27, 2024
30 checks passed
zxdavb added a commit to zxdavb/hass that referenced this pull request Sep 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
@zxdavb zxdavb deleted the evo_tweak_tests1 branch October 6, 2024 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants