Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evohome HVAC modes for VisionPro Wifi systems #126407

Closed
wants to merge 84 commits into from
Closed

Fix evohome HVAC modes for VisionPro Wifi systems #126407

wants to merge 84 commits into from

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Sep 21, 2024 •
edited
Loading

Proposed change

This PR fixes a bug where some systems cannot set the HVAC mode and includes tests that confirm the bug is fixed.

Other tests are affected only in that this PR changes the function that calls async_setup_component() into a generator.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

VisionPro Wifi systems are compatible with Honeywell (now Resideo) TCC, but have slightly different operating modes (e.g. Off instead of HeatingOff). This was mentioned in #32585 (which was closed when the primary issue was addressed in #32604).

Thus, these specific systems cannot be turned on/off via the UI or with the usual service calls.

NOTE: This fix adds a test for service calls (that exposed the bug, and confirms it has been resolved).

This new test includes some changes to conftest.py, and so some changes to other tests.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zxdavb
Squashed commit of the following:
184bfb5 
commit a6651d8
Merge: 359a53a a923f15
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sun Sep 22 00:06:35 2024 +0100

    commit

commit 359a53a
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 23:29:41 2024 +0100

    Rename some evohome constants for clarity / readability (home-assistant#126394)

    initial commit

commit 553e9bc
Author: Erik Montnemery <erik@montnemery.com>
Date:   Sat Sep 21 23:14:12 2024 +0200

    Add issue asking users to disable ESPHome assist_in_progress sensor (home-assistant#125805)

    * Add issue asking users to disable ESPHome assist_in_progress binary sensor

    * Include integration name in title and description

    * Add repair flow

    * Improve test coverage

commit 6792aea
Author: Michael <35783820+mib1185@users.noreply.github.com>
Date:   Sat Sep 21 21:11:17 2024 +0200

    Set connection and command timeout in VLC Telnet (home-assistant#126401)

    use 1s lower than scan interval

commit 45d5021
Author: Allen Porter <allen@thebends.org>
Date:   Sat Sep 21 10:56:13 2024 -0700

    Update the Google Photos integration to limit scope to Home Assistant created content (home-assistant#126398)

commit f222109
Author: Steven B. <51370195+sdb9696@users.noreply.github.com>
Date:   Sat Sep 21 18:03:51 2024 +0100

    Fix tplink number platform to use intended BOX mode (home-assistant#126397)

    The NumberMode should be BOX as per the entity description but due to the missing dataclass decorator was resolving to NumberMode.AUTO.

commit eddb698
Merge: 5a9a19c 2410611
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 15:47:58 2024 +0100

    Merge remote-tracking branch 'upstream/dev' into evo_fix_visionpro

commit 5a9a19c
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 13:37:29 2024 +0100

    un-rename symbols

commit dfe44a1
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 11:40:19 2024 +0100

    move attr to all children of TCS

commit f16565e
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 11:22:12 2024 +0100

    remove tests (for now)

commit 8936c7b
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 11:19:40 2024 +0100

    tweaks to codes

commit be711f5
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 09:31:29 2024 +0100

    Add tests of services and entity methods

commit 862b097
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 09:21:52 2024 +0100

    Refactor evohome for visionpro modes,

commit 5eec2d0
Author: David Bonnes <zxdavb@bonnes.me>
Date:   Sat Sep 21 09:20:19 2024 +0100

    Improve test suit - setup/teardown, use generator, rename symbols
@frenck frenck added this to the 2024.10.0b0 milestone Sep 23, 2024
@zxdavb zxdavb marked this pull request as draft September 24, 2024 18:21
@zxdavb zxdavb marked this pull request as ready for review September 24, 2024 20:16
edenhaus
edenhaus reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this PR into multiple PRs as it includes tests changes, which are not part of the bugfix (like adding tests for all services)

tests/components/evohome/test_init.py Show resolved Hide resolved
tests/components/evohome/test_init.py Show resolved Hide resolved
tests/components/evohome/conftest.py Outdated Show resolved Hide resolved
@edenhaus edenhaus removed this from the 2024.10.0b0 milestone Sep 25, 2024
@zxdavb
Copy link
Contributor Author

zxdavb commented Sep 25, 2024

Can we split this PR into multiple PRs as it includes tests changes, which are not part of the bugfix (like adding tests for all services)

I'll split this out to multiple PRs...

@zxdavb zxdavb marked this pull request as draft September 25, 2024 12:16
@zxdavb zxdavb mentioned this pull request Sep 25, 2024
Merged
19 tasks
@zxdavb zxdavb mentioned this pull request Sep 25, 2024
Merged
19 tasks
@zxdavb
Copy link
Contributor Author

zxdavb commented Sep 25, 2024

Argh!

@zxdavb zxdavb closed this Sep 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@zxdavb zxdavb deleted the evo_fix_vispro branch October 6, 2024 00:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edenhaus edenhaus edenhaus left review comments

@home-assistant home-assistant[bot] home-assistant[bot] requested changes

@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey will be requested when the pull request is marked ready for review dmulcahey is a code owner

@Adminiuga Adminiuga Awaiting requested review from Adminiuga Adminiuga will be requested when the pull request is marked ready for review Adminiuga is a code owner

@puddly puddly Awaiting requested review from puddly puddly will be requested when the pull request is marked ready for review puddly is a code owner

@TheJulianJES TheJulianJES Awaiting requested review from TheJulianJES TheJulianJES will be requested when the pull request is marked ready for review TheJulianJES is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco will be requested when the pull request is marked ready for review bdraco is a code owner

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti will be requested when the pull request is marked ready for review rytilahti is a code owner

@syssi syssi Awaiting requested review from syssi syssi will be requested when the pull request is marked ready for review syssi is a code owner

@starkillerOG starkillerOG Awaiting requested review from starkillerOG starkillerOG will be requested when the pull request is marked ready for review starkillerOG is a code owner

@fabaff fabaff Awaiting requested review from fabaff fabaff will be requested when the pull request is marked ready for review fabaff is a code owner

@gjohansson-ST gjohansson-ST Awaiting requested review from gjohansson-ST gjohansson-ST will be requested when the pull request is marked ready for review gjohansson-ST is a code owner

@thecode thecode Awaiting requested review from thecode thecode will be requested when the pull request is marked ready for review thecode is a code owner

@synesthesiam synesthesiam Awaiting requested review from synesthesiam synesthesiam will be requested when the pull request is marked ready for review synesthesiam is a code owner

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 will be requested when the pull request is marked ready for review chemelli74 is a code owner

@Kane610 Kane610 Awaiting requested review from Kane610 Kane610 will be requested when the pull request is marked ready for review Kane610 is a code owner

@frenck frenck Awaiting requested review from frenck frenck will be requested when the pull request is marked ready for review frenck is a code owner

@ludeeus ludeeus Awaiting requested review from ludeeus ludeeus will be requested when the pull request is marked ready for review ludeeus is a code owner

@bachya bachya Awaiting requested review from bachya bachya will be requested when the pull request is marked ready for review bachya is a code owner

@joostlek joostlek Awaiting requested review from joostlek joostlek will be requested when the pull request is marked ready for review joostlek is a code owner

@raman325 raman325 Awaiting requested review from raman325 raman325 will be requested when the pull request is marked ready for review raman325 is a code owner

@balloob balloob Awaiting requested review from balloob balloob will be requested when the pull request is marked ready for review balloob is a code owner

@bieniu bieniu Awaiting requested review from bieniu bieniu will be requested when the pull request is marked ready for review bieniu is a code owner

@pavoni pavoni Awaiting requested review from pavoni pavoni will be requested when the pull request is marked ready for review pavoni is a code owner

@epenet epenet Awaiting requested review from epenet epenet will be requested when the pull request is marked ready for review epenet is a code owner

@jpbede jpbede Awaiting requested review from jpbede jpbede will be requested when the pull request is marked ready for review jpbede is a code owner

@hunterjm hunterjm Awaiting requested review from hunterjm hunterjm will be requested when the pull request is marked ready for review hunterjm is a code owner

@Quentame Quentame Awaiting requested review from Quentame Quentame will be requested when the pull request is marked ready for review Quentame is a code owner

@allenporter allenporter Awaiting requested review from allenporter allenporter will be requested when the pull request is marked ready for review allenporter is a code owner

@MartinHjelmare MartinHjelmare Awaiting requested review from MartinHjelmare MartinHjelmare will be requested when the pull request is marked ready for review MartinHjelmare is a code owner

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery will be requested when the pull request is marked ready for review emontnemery is a code owner

@jbouwh jbouwh Awaiting requested review from jbouwh jbouwh will be requested when the pull request is marked ready for review jbouwh is a code owner

@farmio farmio Awaiting requested review from farmio farmio will be requested when the pull request is marked ready for review farmio is a code owner

@marvin-w marvin-w Awaiting requested review from marvin-w marvin-w will be requested when the pull request is marked ready for review marvin-w is a code owner

@scop scop Awaiting requested review from scop scop will be requested when the pull request is marked ready for review scop is a code owner

@tronikos tronikos Awaiting requested review from tronikos tronikos will be requested when the pull request is marked ready for review tronikos is a code owner

@mib1185 mib1185 Awaiting requested review from mib1185 mib1185 will be requested when the pull request is marked ready for review mib1185 is a code owner

@OttoWinter OttoWinter Awaiting requested review from OttoWinter OttoWinter will be requested when the pull request is marked ready for review OttoWinter is a code owner

@jesserockz jesserockz Awaiting requested review from jesserockz jesserockz will be requested when the pull request is marked ready for review jesserockz is a code owner

@kbx81 kbx81 Awaiting requested review from kbx81 kbx81 will be requested when the pull request is marked ready for review kbx81 is a code owner

@pvizeli pvizeli Awaiting requested review from pvizeli pvizeli will be requested when the pull request is marked ready for review pvizeli is a code owner

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed has-tests integration: evohome Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.