Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time created to persistent notifications. #17121

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

jeradM
Copy link
Member

@jeradM jeradM commented Oct 4, 2018

Description:

Adds date/time persistent_notification was created

Related frontend PR: home-assistant/frontend#1733

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned balloob Oct 4, 2018
@balloob balloob merged commit cc1891e into home-assistant:dev Oct 4, 2018
@ghost ghost removed the in progress label Oct 4, 2018
@balloob balloob added this to the 0.80 milestone Oct 7, 2018
@balloob
Copy link
Member

balloob commented Oct 7, 2018

Adding to beta because i merged the frontend 🤷‍♂️

@balloob balloob removed this from the 0.80 milestone Oct 7, 2018
@balloob
Copy link
Member

balloob commented Oct 7, 2018

even better, it was already in the beta.

@balloob balloob mentioned this pull request Oct 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants