Add time created to persistent notifications. #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
8 tasks
balloob
reviewed
Oct 4, 2018
| <hui-notification-item-template> | ||
| <span slot="header">[[_computeTitle(notification)]]</span> | ||
|
|
||
| <ha-markdown content="[[notification.message]]"></ha-markdown> | ||
|
|
||
| <ha-relative-time |
There was a problem hiding this comment.
Please wrap this in a paper-tooltip that shows the actual formatted date when hovered. Example
|
Added tooltip to show date using
|
balloob
reviewed
Oct 5, 2018
| @@ -15,11 +17,29 @@ import LocalizeMixin from '../../../../mixins/localize-mixin.js'; | |||
| export class HuiPersistentNotificationItem extends LocalizeMixin(PolymerElement) { | |||
| static get template() { | |||
| return html` | |||
| <style> | |||
| #time { | |||
There was a problem hiding this comment.
IDs need to be unique on a page. This violates that
balloob
reviewed
Oct 5, 2018
| <hui-notification-item-template> | ||
| <span slot="header">[[_computeTitle(notification)]]</span> | ||
|
|
||
| <ha-markdown content="[[notification.message]]"></ha-markdown> | ||
|
|
||
| <div id="time"> |
There was a problem hiding this comment.
notifications need to be unique.
jeradM
force-pushed
the
notification-time
branch
from
2ec480f to
1ed9fe4
Compare
jeradM
force-pushed
the
notification-time
branch
from
1ed9fe4 to
dd8aff9
Compare
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 13, 2018
* Add time created to persistent notifications. * Add tooltip to show actual date. * Fix style rules. * Fix duplicate ids.
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 13, 2018
* Add time created to persistent notifications. * Add tooltip to show actual date. * Fix style rules. * Fix duplicate ids.
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 14, 2018
* Add time created to persistent notifications. * Add tooltip to show actual date. * Fix style rules. * Fix duplicate ids.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds relative creation time to persistent notifications in lovelace notification drawer
Depends on home-assistant/core#17121
Closes home-assistant/ui-schema#170