-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miio push server #64726
Miio push server #64726
Conversation
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
Hey there @rytilahti, @syssi, @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
Marked as draft (instead of W.I.P) |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@MartinHjelmare could you approve this PR or do you have any more feedback? |
@MartinHjelmare whats the process normally to have a PR merged and released on this project? |
This PR is draft as it's waiting for a library release and bump as you can read above. |
@jazomand the upstream PR has already been merged in the dev branch of python-miio, but we are waiting on a new release of python-miio before this can move allong. |
Oh I see. I saw it merged on miio and thought everything was ready, but you are right. The release is not out yet. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Still waiting for upstream |
I suggest closing here until upstream is ready. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Proposed change
Add a push server for the xiaomi miio integration.
This allows for local pushes instead of only polling and will allow for the support of a lot more zigbee devices such as:
NOTE: A NEW VERSION OF PYTHON-MIIO NEEDS TO BE RELEASED FIRSTThe PR for this is here: rytilahti/python-miio#1446 and rytilahti/python-miio#1459
The required upstream changes have been included in HomeAssistant in a version bump of python miio here: #75415
To do:
make documentation: list al newly supported device.add extra testsThis has already been tested locally using 2 gateways simultaniously and it worked butifully.
This requires upstream library PR: rytilahti/python-miio#1521
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: