Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token refresh in samsungtv #66533

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Fix token refresh in samsungtv #66533

merged 5 commits into from
Feb 16, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Feb 14, 2022

Proposed change

Use new token in samsungtv

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @escoand, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

self._remote.token,
)
self.token = self._remote.token
# TODO: copy the new token into the config entry
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't update the config entry, then it we cannot use it again after a restart.

@epenet epenet changed the title Use new token in samsungtv Fix token refresh in samsungtv Feb 14, 2022
@nmaciasc
Copy link

I this PR going through any time soon? Im still having this issue and would love a fix instead of "reconfigure" my TV every single day

@epenet
Copy link
Contributor Author

epenet commented Feb 16, 2022

I'm still trying to fix the tests.
It needs #66650 before I can move forward

@epenet epenet added this to the 2022.2.8 milestone Feb 16, 2022
@epenet epenet marked this pull request as draft February 16, 2022 19:46
@epenet epenet force-pushed the samsungtv branch 4 times, most recently from 65a8d9c to 44ac21e Compare February 16, 2022 20:10
@epenet epenet marked this pull request as ready for review February 16, 2022 20:26
@balloob balloob merged commit 2d33e43 into home-assistant:dev Feb 16, 2022
balloob pushed a commit that referenced this pull request Feb 16, 2022
@epenet epenet deleted the samsungtv branch February 16, 2022 20:28
@balloob balloob mentioned this pull request Feb 16, 2022
@c58
Copy link

c58 commented Feb 17, 2022

awesome! thank you so much @epenet !

@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants