Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SamsungTVWS mocking in samsungtv tests #66650

Merged
merged 12 commits into from
Feb 16, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Feb 16, 2022

Proposed change

Ensure the __enter__ method mock returns the correct object, so that we can apply further patching outside of the fixture.

As per https://github.com/xchwarze/samsung-tv-ws-api/blob/d539372cb7dc93e7b94bb3fdf5cc57f585b69e45/samsungtvws/remote.py#L36

class SamsungTVWS:
    ...

    def __enter__(self):
        return self

Needed for #66651

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @escoand, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet marked this pull request as draft February 16, 2022 13:23
@epenet epenet mentioned this pull request Feb 16, 2022
22 tasks
@epenet epenet marked this pull request as ready for review February 16, 2022 15:15
@epenet epenet changed the title Fix remotews fixtures in samsungtv tests Fix SamsungTVWS mocking in samsungtv tests Feb 16, 2022
@epenet epenet mentioned this pull request Feb 16, 2022
22 tasks
@balloob balloob merged commit 14e48ba into home-assistant:dev Feb 16, 2022
@epenet epenet deleted the samsung-remotews branch February 16, 2022 20:13
@balloob balloob modified the milestone: 2022.2.8 Feb 16, 2022
balloob pushed a commit that referenced this pull request Feb 16, 2022
Co-authored-by: epenet <epenet@users.noreply.github.com>
@balloob balloob mentioned this pull request Feb 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants