Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Big Ass Fans integration #71498

Merged
merged 37 commits into from
May 14, 2022
Merged

Add Big Ass Fans integration #71498

merged 37 commits into from
May 14, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 7, 2022

Proposed change

Add Big Ass Fans integration

BAF is migrating all their products to a single platform which the i6 and their other fans use (new protocol, new discovery method, new design that is not 1:1 compatible).

Additionally, the SenseME integration will eventually go away as users upgrade the firmware https://alerts.home-assistant.io/#senseme.markdown as the Haiku fans and old discontinued lights are the only products that still use the old platform.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review May 8, 2022 19:03
bdraco and others added 4 commits May 14, 2022 16:24
@bdraco
Copy link
Member Author

bdraco commented May 14, 2022

Retest is good. Everything still works.

@bdraco bdraco merged commit 51c6a68 into home-assistant:dev May 14, 2022
@bdraco
Copy link
Member Author

bdraco commented May 14, 2022

Thanks 👍

@jfroy
Copy link
Contributor

jfroy commented May 15, 2022

Awesome 🥇

@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants