Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Big Ass Fans integration #22671

Merged
merged 1 commit into from
May 14, 2022
Merged

Add Big Ass Fans integration #22671

merged 1 commit into from
May 14, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 7, 2022

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me. Looking at other integration documentation it seems usual to describe some of the sensors/features exposed by the integration.

But I didn't see that here, maybe that's intentional?

@bdraco
Copy link
Member Author

bdraco commented May 8, 2022

The content looks good to me. Looking at other integration documentation it seems usual to describe some of the sensors/features exposed by the integration.

But I didn't see that here, maybe that's intentional?

Thanks @davet2001

There are 6 more platforms coming which probably need some explanation, but they will come in future merges.

@klaasnicolaas klaasnicolaas added the new-integration This PR adds documentation for a new Home Assistant integration label May 8, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label May 9, 2022
@bdraco bdraco merged commit 23afc57 into home-assistant:next May 14, 2022
@probot-home-assistant probot-home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label May 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants