-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Switchbot Blind Tilt #86591
Conversation
Hey there @bdraco, @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I tested locally and it seems like the state is staying Additionally, it's causing this error with google assistant integration (possibly related to state showing unavailable): (#43178)
|
I ordered a set of these to test with. Will test this PR when they show up |
I pulled this branch and can confirm everything works great so far |
The way the blinds operate with 50%=open conflicts with the way covers are expected to behave. For example, when exposed to google home, it assumes the blinds are at 100% when open, but they are actually at This can be worked around by creating a cover template and adding some math to scale and offset tilt values in service calls. However, this has to be done in yaml, and it can be daunting for those without any experience writing HA yaml/programming to do this (without a step-by-step guide). Owners can decide if this is acceptable. Another option would be implementing a
Example cover template (close down):
|
…PySwitchbot==0.37.1 api (#86990) update _is_opening, _is_closing to use 0.37.1 api
Device showed up. Did some very basic testing. All good 👍 |
Please don’t ping asking for reviews
|
Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: BelowAverageDeveloper <90269575+BelowAverageDev@users.noreply.github.com>
Proposed change
Add support for SwitchBot Blind Tilt
Library changelog: sblibs/pySwitchbot@0.36.4...0.37.1
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: