Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show currently selected language in profile settings. Resolves #1797 #1800

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Show currently selected language in profile settings. Resolves #1797 #1800

merged 1 commit into from
Oct 18, 2018

Conversation

thomasloven
Copy link
Contributor

No description provided.

@ghost ghost assigned thomasloven Oct 17, 2018
@ghost ghost added the in progress label Oct 17, 2018
@zsarnett
Copy link
Contributor

zsarnett commented Oct 18, 2018 •
edited
Loading

Would using a computed property be better in this case?

languageSelection: {
  type: String,
  observer: "_languageSelectionChanged",
  computed: "_computeLanguage(hass.language)",

_computeLanguage(language) {
  return language;
}

@zsarnett
Copy link
Contributor

Actually this doesn't seem to be working. Setting the computed Property disables the observer for some reason

@balloob balloob merged commit 9d13925 into master Oct 18, 2018
@balloob balloob deleted the fix-current-language-not-shown branch October 18, 2018 07:55
@ghost ghost removed the in progress label Oct 18, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees

@thomasloven thomasloven

Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomasloven @zsarnett @balloob @cgarwood @homeassistant