-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity dropdown improvement #674
Conversation
}; | ||
assert(!hasLocation(stateObj)); | ||
}); | ||
it('does not flag states with no location', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'it' is not defined no-undef
}; | ||
assert(!hasLocation(stateObj)); | ||
}); | ||
it('does not flag states with only longitude', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'it' is not defined no-undef
}; | ||
assert(hasLocation(stateObj)); | ||
}); | ||
it('does not flag states with only latitude', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'it' is not defined no-undef
const assert = require('assert'); | ||
|
||
describe('hasLocation', () => { | ||
it('flags states with location', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'it' is not defined no-undef
|
||
const assert = require('assert'); | ||
|
||
describe('hasLocation', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'describe' is not defined no-undef
@@ -0,0 +1,38 @@ | |||
import { hasLocation } from '../../../js/common/util/location'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../../js/common/util/location' import/no-unresolved
Missing file extension for "../../../js/common/util/location" import/extensions
@@ -1,30 +1,56 @@ | |||
import { h, Component } from 'preact'; | |||
|
|||
import { onChangeEvent } from '../../util/event'; | |||
import { hasLocation } from '../../util/location'; | |||
import computeDomain from '../../util/compute_domain'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../util/compute_domain' import/no-unresolved
Missing file extension for "../../util/compute_domain" import/extensions
@@ -1,30 +1,56 @@ | |||
import { h, Component } from 'preact'; | |||
|
|||
import { onChangeEvent } from '../../util/event'; | |||
import { hasLocation } from '../../util/location'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../util/location' import/no-unresolved
Missing file extension for "../../util/location" import/extensions
js/automation-editor/trigger/zone.js
Outdated
@@ -1,13 +1,35 @@ | |||
import { h, Component } from 'preact'; | |||
|
|||
import { onChangeEvent } from '../../common/util/event'; | |||
import { hasLocation } from '../../common/util/location'; | |||
import computeDomain from '../../common/util/compute_domain'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../common/util/compute_domain' import/no-unresolved
Missing file extension for "../../common/util/compute_domain" import/extensions
js/automation-editor/trigger/zone.js
Outdated
@@ -1,13 +1,35 @@ | |||
import { h, Component } from 'preact'; | |||
|
|||
import { onChangeEvent } from '../../common/util/event'; | |||
import { hasLocation } from '../../common/util/location'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../common/util/location' import/no-unresolved
Missing file extension for "../../common/util/location" import/extensions
* Update script and automation editor to use entity picker * Add entity and service picker to service dev panel * Lint
c155da0
to
c0e3213
Compare
<ha-combo-box>
for ha-dev-service using vaadin-combo-box-light around paper-input for material design<ha-combo-box>
to<ha-entity-picker>
because composition is not working out for passing a template for an item in.100vh