Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity dropdown improvement #674

Merged
merged 7 commits into from
Nov 26, 2017
Merged

Entity dropdown improvement #674

merged 7 commits into from
Nov 26, 2017

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 24, 2017

  • Update vaadin-combo-box to v3 (no longer is material design)
  • Create <ha-combo-box> for ha-dev-service using vaadin-combo-box-light around paper-input for material design
  • Fork <ha-combo-box> to <ha-entity-picker> because composition is not working out for passing a template for an item in.
  • Fix height of the menu by setting vertical height of body element to 100vh
  • Ignore hass changes while dropdown is open because it resets the scroller to top
  • Rename ha-entity-dropdown to ha-entity-picker (being a dropdown is an implementation detail)

@andrey-git andrey-git changed the title Enttiy dropdown improvement Entity dropdown improvement Nov 25, 2017
};
assert(!hasLocation(stateObj));
});
it('does not flag states with no location', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'it' is not defined no-undef

};
assert(!hasLocation(stateObj));
});
it('does not flag states with only longitude', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'it' is not defined no-undef

};
assert(hasLocation(stateObj));
});
it('does not flag states with only latitude', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'it' is not defined no-undef

const assert = require('assert');

describe('hasLocation', () => {
it('flags states with location', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'it' is not defined no-undef


const assert = require('assert');

describe('hasLocation', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'describe' is not defined no-undef

@@ -0,0 +1,38 @@
import { hasLocation } from '../../../js/common/util/location';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../../js/common/util/location' import/no-unresolved
Missing file extension for "../../../js/common/util/location" import/extensions

@@ -1,30 +1,56 @@
import { h, Component } from 'preact';

import { onChangeEvent } from '../../util/event';
import { hasLocation } from '../../util/location';
import computeDomain from '../../util/compute_domain';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../util/compute_domain' import/no-unresolved
Missing file extension for "../../util/compute_domain" import/extensions

@@ -1,30 +1,56 @@
import { h, Component } from 'preact';

import { onChangeEvent } from '../../util/event';
import { hasLocation } from '../../util/location';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../util/location' import/no-unresolved
Missing file extension for "../../util/location" import/extensions

@@ -1,13 +1,35 @@
import { h, Component } from 'preact';

import { onChangeEvent } from '../../common/util/event';
import { hasLocation } from '../../common/util/location';
import computeDomain from '../../common/util/compute_domain';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../common/util/compute_domain' import/no-unresolved
Missing file extension for "../../common/util/compute_domain" import/extensions

@@ -1,13 +1,35 @@
import { h, Component } from 'preact';

import { onChangeEvent } from '../../common/util/event';
import { hasLocation } from '../../common/util/location';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../common/util/location' import/no-unresolved
Missing file extension for "../../common/util/location" import/extensions

@balloob balloob force-pushed the enttiy-dropdown-improvement branch from c155da0 to c0e3213 Compare November 25, 2017 23:42
@balloob balloob merged commit 0707528 into master Nov 26, 2017
@balloob balloob deleted the enttiy-dropdown-improvement branch November 26, 2017 00:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants