Expose entities for Google/Alexa #680

balloob · 2017-11-25T08:19:43Z

This ports the entity filter function from Home Assistant from Python to JavaScript. We will be able to use this function to power a user interface for exposing entities for Google Assistant, Emulated Hue, Alexa (as per #679)

Implemented function on the cloud dashboard.

Requires: home-assistant/core#18216

test-mocha/common/util/entity_filter.js

test-mocha/common/util/compute_state_domain.js

js/util.js

js/common/util/compute_state_display.js

test-mocha/common/util/entity_filter.js

test-mocha/common/util/compute_state_domain.js

js/util.js

js/common/util/compute_state_display.js

houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:

.eslintrc:
	Configuration for rule "import/extensions" is invalid:
	Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').
Error: .eslintrc:

at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)

at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)

at Array.forEach ()

at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)

at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)

at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)

at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)

at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)

at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)

at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)

houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:

.eslintrc:
	Configuration for rule "import/extensions" is invalid:
	Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"always"').
Error: .eslintrc:

at validateRuleOptions (/app/node_modules/eslint/lib/config/config-validator.js:113:15)

at Object.keys.forEach.id (/app/node_modules/eslint/lib/config/config-validator.js:153:9)

at Array.forEach ()

at validateRules (/app/node_modules/eslint/lib/config/config-validator.js:152:30)

at Object.validate (/app/node_modules/eslint/lib/config/config-validator.js:230:5)

at loadFromDisk (/app/node_modules/eslint/lib/config/config-file.js:549:19)

at Object.load (/app/node_modules/eslint/lib/config/config-file.js:592:20)

at Config.getLocalConfigHierarchy (/app/node_modules/eslint/lib/config.js:226:44)

at Config.getConfigHierarchy (/app/node_modules/eslint/lib/config.js:180:43)

at Config.getConfigVector (/app/node_modules/eslint/lib/config.js:285:21)

houndci-bot · 2017-11-25T08:24:46Z

test-mocha/common/util/entity_filter.js

@@ -0,0 +1,88 @@
+import entityFilter from '../../../js/common/util/entity_filter';


Missing file extension for "../../../js/common/util/entity_filter" import/extensions

test-mocha/common/util/compute_state_domain.js

js/util.js

andrey-git · 2017-11-25T08:27:34Z

I think each new function should have at least one (non test) use

andrey-git · 2017-11-25T08:29:33Z

Is the lint change specific for hound or is it relevant for local eslint too?

balloob · 2017-11-25T08:39:34Z

I agree that we need non-test use. Waiting for #674 and #675 to land 👍 .

Eslint changes are relevant for local too.

balloob · 2017-11-25T19:15:29Z

extracted eslint stuff.

ciotlosm · 2018-07-15T10:53:43Z

I assume this is no longer relevant?

balloob · 2018-07-15T12:03:17Z

It is relevant but need to build UI that uses it. It is for Alexa and Google Assistant to decide what to expose.

balloob · 2018-11-05T10:33:34Z

balloob · 2018-11-05T15:04:48Z

Blocked by converting tests to TS first.

homeassistant added the cla-signed label Nov 25, 2017

houndci-bot reviewed Nov 25, 2017

View reviewed changes

test-mocha/common/util/entity_filter.js Outdated Show resolved Hide resolved

test-mocha/common/util/compute_state_domain.js Outdated Show resolved Hide resolved

js/util.js Outdated Show resolved Hide resolved

js/common/util/compute_state_display.js Outdated Show resolved Hide resolved

houndci-bot reviewed Nov 25, 2017

View reviewed changes

test-mocha/common/util/entity_filter.js Outdated Show resolved Hide resolved

test-mocha/common/util/compute_state_domain.js Outdated Show resolved Hide resolved

js/util.js Outdated Show resolved Hide resolved

js/common/util/compute_state_display.js Outdated Show resolved Hide resolved

houndci-bot reviewed Nov 25, 2017

View reviewed changes

home-assistant deleted a comment from houndci-bot Nov 25, 2017

balloob force-pushed the add-entity-filter branch from dfe22dc to 4eaba14 Compare November 25, 2017 08:40

homeassistant added the cla-signed label Nov 25, 2017

balloob mentioned this pull request Nov 25, 2017

Fix eslint import extension #682

Merged

balloob force-pushed the add-entity-filter branch from 2afd23e to d6587cf Compare November 25, 2017 19:15

homeassistant added the cla-signed label Nov 25, 2017

balloob force-pushed the add-entity-filter branch from d6587cf to f149f93 Compare October 12, 2018 12:29

ghost assigned balloob Oct 12, 2018

ghost added the in progress label Oct 12, 2018

balloob force-pushed the add-entity-filter branch 2 times, most recently from 1907d28 to a0611c2 Compare October 12, 2018 12:34

balloob changed the base branch from master to dev October 27, 2018 08:55

balloob force-pushed the add-entity-filter branch 2 times, most recently from 6cfd142 to 95eb6db Compare November 5, 2018 10:14

balloob changed the title ~~Add entity filter util function~~ Expose entities for Google/Alexa Nov 5, 2018

balloob mentioned this pull request Nov 5, 2018

Cloud conf home-assistant/core#18216

Merged

3 tasks

balloob mentioned this pull request Nov 5, 2018

Ts all the tests #1998

Merged

balloob force-pushed the add-entity-filter branch from ddda31a to 93a6994 Compare November 6, 2018 09:12

balloob and others added 7 commits November 6, 2018 11:52

Add entity filter

35c846c

Show exposed entities on cloud panel

b7fae79

Fix tests

d3dd3e4

Revert some testing changes

b41ec02

Cursor: pointer

5ad2625

Fix

019367c

Update tests to TS

960ef88

balloob force-pushed the add-entity-filter branch from dcb1c02 to 960ef88 Compare November 6, 2018 10:52

balloob merged commit e2b9893 into dev Nov 6, 2018

ghost removed the in progress label Nov 6, 2018

balloob deleted the add-entity-filter branch November 6, 2018 13:23

balloob mentioned this pull request Nov 21, 2018

Merge 20181121.0 to master #2077

Merged

github-actions bot locked and limited conversation to collaborators Jul 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose entities for Google/Alexa #680

Expose entities for Google/Alexa #680

balloob commented Nov 25, 2017 •

edited

Loading

houndci-bot left a comment

houndci-bot left a comment

houndci-bot Nov 25, 2017

andrey-git commented Nov 25, 2017

andrey-git commented Nov 25, 2017

balloob commented Nov 25, 2017

balloob commented Nov 25, 2017

ciotlosm commented Jul 15, 2018

balloob commented Jul 15, 2018

balloob commented Nov 5, 2018

balloob commented Nov 5, 2018

		@@ -0,0 +1,88 @@
		import entityFilter from '../../../js/common/util/entity_filter';

Expose entities for Google/Alexa #680

Expose entities for Google/Alexa #680

Conversation

balloob commented Nov 25, 2017 • edited Loading

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot Nov 25, 2017

Choose a reason for hiding this comment

andrey-git commented Nov 25, 2017

andrey-git commented Nov 25, 2017

balloob commented Nov 25, 2017

balloob commented Nov 25, 2017

ciotlosm commented Jul 15, 2018

balloob commented Jul 15, 2018

balloob commented Nov 5, 2018

balloob commented Nov 5, 2018

balloob commented Nov 25, 2017 •

edited

Loading