Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint import extension #682

Merged
merged 3 commits into from
Nov 25, 2017
Merged

Fix eslint import extension #682

merged 3 commits into from
Nov 25, 2017

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 25, 2017

Extracted ESLint fixes from #680. Also renames computeDomain to computeStateDomain and extracts computeDomain as one that takes in an entityId.

@@ -0,0 +1,12 @@
import computeStateDomain from '../../../js/common/util/compute_state_domain.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../../js/common/util/compute_state_domain.js' import/no-unresolved
Unexpected use of file extension "js" for "../../../js/common/util/compute_state_domain.js" import/extensions

import computeStateDisplay from './common/util/compute_state_display.js';
import formatDate from './common/util/format_date.js';
import formatDateTime from './common/util/format_date_time.js';
import formatTime from './common/util/format_time.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/format_time.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/format_time.js" import/extensions

import computeStateDomain from './common/util/compute_state_domain.js';
import computeStateDisplay from './common/util/compute_state_display.js';
import formatDate from './common/util/format_date.js';
import formatDateTime from './common/util/format_date_time.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/format_date_time.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/format_date_time.js" import/extensions

import attributeClassNames from './common/util/attribute_class_names.js';
import computeStateDomain from './common/util/compute_state_domain.js';
import computeStateDisplay from './common/util/compute_state_display.js';
import formatDate from './common/util/format_date.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/format_date.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/format_date.js" import/extensions

import formatTime from './common/util/format_time';
import attributeClassNames from './common/util/attribute_class_names.js';
import computeStateDomain from './common/util/compute_state_domain.js';
import computeStateDisplay from './common/util/compute_state_display.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './common/util/compute_state_display.js' import/no-unresolved
Unexpected use of file extension "js" for "./common/util/compute_state_display.js" import/extensions

import formatTime from './format_time';
import computeStateDomain from './compute_state_domain.js';
import formatDateTime from './format_date_time.js';
import formatDate from './format_date.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './format_date.js' import/no-unresolved
Unexpected use of file extension "js" for "./format_date.js" import/extensions

import formatDate from './format_date';
import formatTime from './format_time';
import computeStateDomain from './compute_state_domain.js';
import formatDateTime from './format_date_time.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './format_date_time.js' import/no-unresolved
Unexpected use of file extension "js" for "./format_date_time.js" import/extensions

import formatDateTime from './format_date_time';
import formatDate from './format_date';
import formatTime from './format_time';
import computeStateDomain from './compute_state_domain.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './compute_state_domain.js' import/no-unresolved
Unexpected use of file extension "js" for "./compute_state_domain.js" import/extensions

@@ -1,5 +1,5 @@
import { h, Component } from 'preact';
import { onChangeEvent } from '../../util/event';
import { onChangeEvent } from '../../util/event.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../util/event.js' import/no-unresolved
Unexpected use of file extension "js" for "../../util/event.js" import/extensions

@@ -1,6 +1,6 @@
import { h, Component } from 'preact';

import ActionRow from './action_row';
import ActionRow from './action_row.js';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './action_row.js' import/no-unresolved
Unexpected use of file extension "js" for "./action_row.js" import/extensions

@balloob
Copy link
Member Author

balloob commented Nov 25, 2017

sigh, forgot the updated eslint config. Oh Hound, you so spammy.

@balloob balloob merged commit 2845774 into master Nov 25, 2017
@balloob balloob deleted the fix-eslint-import-extension branch November 26, 2017 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants