Breakup load into separate functions #360
Conversation
This splits off the actual loading of the JSON file and parsing into a new function. The idea is that eventually I'd like to make modifying the configuration file available to the code base.
| @@ -49,6 +47,17 @@ bool Config::load() { | |||
| JsonObject& parsedJson = jsonBuffer.parseObject(buf); | |||
There was a problem hiding this comment.
jsonBuffer is a local variable, so you create a reference to something internal to this local variable.
The local variable gets destroyed when leaving Config::load(), this (hopefully ;-) frees the buffer of parsedJson.
| bool Config::load() { | ||
| _valid = false; | ||
| JsonObject& parsedJson = Config::loadJSONObject(); | ||
| if (!parsedJson.success()) { |
There was a problem hiding this comment.
parsedJson is freed memory, so behaviour is undefined. (It will work in most cases anyhow, because no one else has overwritten the memory region yet... but technically this is just good luck....)
There was a problem hiding this comment.
It's been a decade or two since I've done any real C++ coding. Thanks for the sanity check.
|
This has been done in #458 differently and in a safer manner (event though my c++ is basic ... lots of googling) , thus im closing, if you have any comments please add :) |
|
Excellent. I'll have to make some time to test it out. |
This splits off the actual loading of the JSON file and parsing into a new function. The idea is that eventually I'd like to make modifying the configuration file available to the code base.
I'm not sure what the best method for exposing the configuration is, but this is a start.