Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards V2.1 #458

Closed
wants to merge 62 commits into from
Closed

Towards V2.1 #458

wants to merge 62 commits into from

Conversation

timpur
Copy link
Contributor

@timpur timpur commented Dec 22, 2017

marvinroger and others added 5 commits September 22, 2016 10:40
…eiot#416)

* Backport config parsing fix, a964b78 from upstream

* bodyCharArray no longer exists so do not try to free it
- Refactored Firmware Name + Version + Brand
- Refactor of Config + Added Write Validation + Load Validation + Moved all Validating to the Config
- Remove Settings item via set to null + Revert if save of config fails
Thomas Dietrich and others added 7 commits December 27, 2017 09:28
* Add last step to uibundle README

* Added Arduino Support for doc
- Alow removal of setting items
- Alow adding of settings items when settings object didnt originally exists in config.
@timpur timpur mentioned this pull request Jan 2, 2018
@timpur timpur added this to the v2.1.0 milestone Jan 2, 2018
@timpur timpur mentioned this pull request May 9, 2018
@euphi
Copy link
Member

euphi commented Mar 9, 2019

@timpur Do you know, why this PR was never merged? I try to get an overview of the changes, but these are too many to understand them soon 😱 . However, it seems at least some of them are useful also for #develop-v3 branch.

@timpur
Copy link
Contributor Author

timpur commented Mar 10, 2019

@euphi think i was to ambitious with the task list :P

Maybe best to port some of the changes to the new branch ... ?

@euphi
Copy link
Member

euphi commented Mar 10, 2019

Interestingly, therre is no merge conflict, although there were some many other commits on the #develop branch.

@euphi
Copy link
Member

euphi commented Mar 10, 2019

@timpur Can you help with selecting the important commits? (Or help with testing. especially the changes to config mode, because I don't use the config mode).

@timpur
Copy link
Contributor Author

timpur commented Mar 10, 2019

I will try help out when I can :)

Though I welcome others to also Chery pick commits into smaller PRs. I should of done this ...

@euphi euphi mentioned this pull request Mar 19, 2019
@stritti
Copy link
Collaborator

stritti commented Jan 2, 2020

I close this PR. Most features are implemented on #develop-v3 now.

@stritti stritti closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants