Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options link in page extension. #990

Merged
merged 3 commits into from
May 9, 2014

Conversation

matheod
Copy link
Collaborator

@matheod matheod commented Apr 30, 2014

No description provided.

<!doctype html>
<html>
<head>
<meta http-equiv="refresh" content="0;URL=http://www.reddit.com/#!settings/accountSwitcher">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO should just be #!settings -- the /accountSwitcher part should happen naturally, shouldn't be explicitly declared

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, I get tricked :D
I tried this url but when the console was open. So I believed the link didn't work because it close the console but it's because it was open :D

@honestbleeps
Copy link
Owner

hrm, this is chrome specific then... and it'll just open reddit to the options page?

should we make this (if / when possible) for all browsers?

@matheod
Copy link
Collaborator Author

matheod commented May 6, 2014

Yea this add an option link to the RES options on the chrome extension page.

For firefox, I'm not sure this is possible. Options pages are built by firefox from data we give them (eg. text field, select, etc.) but I don't think we can make the options link to an Url.

@honestbleeps
Copy link
Owner

i think this should at least be done for Chropera (Opera 20+) - is it doable there?

(untested, but should work !)
@matheod
Copy link
Collaborator Author

matheod commented May 8, 2014

Done, I can't test because I don't have Opera, but this should work :)

@jewel-andraia
Copy link
Collaborator

because I don't have Opera

Then install it, you goober!

@matheod
Copy link
Collaborator Author

matheod commented May 8, 2014

With all the bad I heard on it ? (the new version, not the old)

2014-05-08 18:14 GMT+02:00 Andy Tuba notifications@github.com:

because I don't have Opera

Then install it, you goober!


Reply to this email directly or view it on GitHubhttps://github.com//pull/990#issuecomment-42570028
.

@jewel-andraia
Copy link
Collaborator

Well, it won't break your computer. It just doesn't have as many features as Opera 12.

@matheod
Copy link
Collaborator Author

matheod commented May 9, 2014

Work on Opera

honestbleeps added a commit that referenced this pull request May 9, 2014
Added options link in page extension.
@honestbleeps honestbleeps merged commit b1fe602 into honestbleeps:master May 9, 2014
@jewel-andraia jewel-andraia mentioned this pull request May 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants