Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options link in page extension. #990

Merged
merged 3 commits into from
May 9, 2014
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Chrome/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"scripts": ["background.js"]
},
"homepage_url": "http://redditenhancementsuite.com",
"options_page": "options.html",
"content_scripts": [
{
"matches": [
Expand Down
7 changes: 7 additions & 0 deletions Chrome/options.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!doctype html>
<html>
<head>
<meta http-equiv="refresh" content="0;URL=http://www.reddit.com/#!settings/accountSwitcher">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO should just be #!settings -- the /accountSwitcher part should happen naturally, shouldn't be explicitly declared

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, I get tricked :D
I tried this url but when the console was open. So I believed the link didn't work because it close the console but it's because it was open :D

</head>
<body></body>
</html>