ci: prettify type check result and rm a comment (#3442)

honojs · Sep 23, 2024 · 4878fcf · 4878fcf
1 parent e1eb98d
commit 4878fcf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -180,9 +180,6 @@ jobs:
 
  perf-measures-type-check-on-pr:
  runs-on: ubuntu-latest
- permissions:
- contents: 'read'
- pull-requests: 'write'
  if: github.event_name == 'pull_request'
  steps:
  - uses: actions/checkout@v4
@@ -201,16 +198,12 @@ jobs:
  - run: |
  {
  echo 'COMPARISON<<EOF'
- bun scripts/process-results.ts
+ bun scripts/process-results.ts | column -s '|' -t
  echo 'EOF'
  } >> "$GITHUB_ENV"
  working-directory: perf-measures/type-check
  - run: echo "$COMPARISON"
- # remove the comment out after we make sure that caching is working
- # - uses: thollander/actions-comment-pull-request@v2
- # with:
- # comment_tag: perf-measures/type-check
- # message: ${{ env.COMPARISON }}
+ name: display comparison
 
 
  perf-measures-type-check-on-main:

diff --git a/perf-measures/type-check/scripts/process-results.ts b/perf-measures/type-check/scripts/process-results.ts
@@ -5,7 +5,7 @@ async function main() {
  const previousResult = await fs.readFile('./previous-result.txt')
  .then((data) => data.toString().split('\n'))
  .catch(() => null)
- const table = ['|| Current | Previous |', '|---|---|---|'] 
+ const table = ['| | Current | Previous |', '| --- | --- | --- |']
  for (const [i, line] of currentResult.entries()) {
  if (line === '') {continue}
  const [name, value] = line.split(':')