Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prettify type check result and rm a comment #3442

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

m-shaka
Copy link
Contributor

@m-shaka m-shaka commented Sep 23, 2024

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

We decided not posting the result so rm the comment-outed lines and format the table to get better view in the detail page of workflow
#3438

image

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (e1eb98d) to head (43877c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3442   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         155      155           
  Lines        9313     9313           
  Branches     2795     2719   -76     
=======================================
  Hits         8920     8920           
  Misses        393      393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-shaka m-shaka marked this pull request as ready for review September 23, 2024 06:55
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Easy to read! Thank you!

@yusukebe yusukebe merged commit 4878fcf into honojs:main Sep 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants