Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: post result of perf-measures/type-check #3438

Closed

Conversation

m-shaka
Copy link
Contributor

@m-shaka m-shaka commented Sep 22, 2024

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@m-shaka
Copy link
Contributor Author

m-shaka commented Sep 22, 2024

@yusukebe I tried to post a comment from a workflow, but I got Resource not accessible by integration error
https://github.com/honojs/hono/actions/runs/10980454233/job/30486253901?pr=3438#step:10:47

According to the document of the action, we need to use pull_request_target event instead of pull_request to post comments to the PR from a forked repository, but I wouldn't like to do that.
https://github.com/thollander/actions-comment-pull-request/tree/v2/?tab=readme-ov-file#permissions

Now we can see the comparison in the workflow detail page, so I think posting it as a comment is not always necessary.
image

Or do you have any better idea?

@yusukebe
Copy link
Member

@m-shaka

I also don't want to use the pull_request_target.

Now we can see the comparison in the workflow detail page, so I think posting it as a comment is not always necessary.

Agree. Posting a comment is unnecessary.

Then, if we go without it, should I merge this PR?

@m-shaka
Copy link
Contributor Author

m-shaka commented Sep 23, 2024

Ok! I'm closing this PR and create another one to remove the comment in ci.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants