feat(jsx/dom): export createRoot and hydrateRoot from jsx/dom/client as default #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 136 136
Lines 13343 13348 +5
Branches 2219 2248 +29
=======================================
+ Hits 12599 12604 +5
Misses 744 744 ☔ View full report in Codecov by Sentry. |
|
Thank @usualoma ! I'm wondering which version we should include this change in. So, keeping not merging for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small additions to make #2925 easier to implement.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code