Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @hono/react-compat package #563

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

usualoma
Copy link
Member

@usualoma usualoma commented Jun 8, 2024

The dependency on Hono version is weak and can be used for "4.x", but currently ">= 4.5.*" is specified for peerDependencies, as a merged release of honojs/hono#2929 and honojs/hono#2930 would work more fully.

https://github.com/honojs/middleware/compare/main...usualoma:middleware:feat/react-compat?expand=1#diff-290f95d23c372b783139084b0b97bef9100b22c677ab0497121b834c8ca38f86R28

The creation of this package was proposed by Gaetan Puleo.

Co-authored-by: Gaetan Puleo <pro@gaetanpuleo.com>
Copy link

changeset-bot bot commented Jun 8, 2024

🦋 Changeset detected

Latest commit: 4e2469a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/react-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@usualoma usualoma changed the title Add @hono/react-compat package feat: add @hono/react-compat package Jun 8, 2024
@yusukebe
Copy link
Member

Hey @usualoma !

I fixed some issues to work this package correctly myself. I left what I did in the commit messages. Can you check these changes?

If it's okay, we can release it as v0.0.1 and use it with the hono v4.5.0-rc.1, though it is not adaptable to the peer dependencies.

@usualoma
Copy link
Member Author

@yusukebe
Confirmed.
The default export is indeed right, I made a mistake.
Thanks for the correction.

Let's go with this!

@yusukebe
Copy link
Member

@usualoma Thanks! I'll release this now.

@yusukebe yusukebe merged commit 2b98110 into honojs:main Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants