This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
PR to see diff (while we fix this) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
till
force-pushed
the
debug-build
branch
2 times, most recently
from
193a673
to
5b393c2
Compare
I am not sure where to start, we run against ory platform and noticed that the response "from" oathkeeper did not contain a subject when it got to the backend service. I managed to find out that the "body" in `forwardRequestToSessionStore()` was nil/empty in some cases and the gjson calls failed silently. I started log.Printf() debugging in these two service files and simplified the code a bit to make it more readable. And that seemed to have fixed it.
Related: ory#836
Related: ory#836
[skip ci]
Replaced by ory/meta#154
[skip ci] - updated repository templates to ory/meta@81cbfd3
[skip ci] - updated repository templates to ory/meta@44cf1a8
[skip ci] - updated repository templates to ory/meta@32137ce
[skip ci] - updated repository templates to ory/meta@4301832
[skip ci]
…ed (ory#1061) With this change, Oathkeeper now reports as "not ready" on the health check if not at least one valid rule is loaded.
- refactors test helpers into middleware_test.go - provides a "complete" response from the test server - complete response is necessary in order to provide subject (to allow the request)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: pngmbh/issues#1066