Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the rules total count not updating post archiving a rule, bottom line not visible for included facility groups item and add a required astrick in case of Channels selection #275

Closed
2 tasks
amansinghbais opened this issue Apr 30, 2024 · 0 comments
Closed
2 tasks

Fix the rules total count not updating post archiving a rule, bottom line not visible for included facility groups item and add a required astrick in case of Channels selection #275

amansinghbais opened this issue Apr 30, 2024 · 0 comments
Labels
bug Something isn't working release-v3.0.0

Comments

@amansinghbais
Copy link
Contributor

Current behavior

  • Currently when we archive a rule, the rule gets removed from the list but total rule count not updates.
  • Bottom line is not visible for the included facility group items in rule card.

Expected behavior

  • Update the rule count when we archive a rule.
  • Display bottom line for the included facility groups.
  • Improve creation UI for showing Channels mandatory by using red astrick.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@amansinghbais amansinghbais added the bug Something isn't working label Apr 30, 2024
@amansinghbais amansinghbais self-assigned this Apr 30, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Apr 30, 2024
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Apr 30, 2024
@amansinghbais
Fixed: rules total count not updating on archiving rule, showed botto…
ee5cfdc 
…m line in rule card and required astrick in case of channels (hotwax#275)
@amansinghbais amansinghbais mentioned this issue Apr 30, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Apr 30, 2024
ymaheshwari1 added a commit that referenced this issue Apr 30, 2024
@ymaheshwari1
Merge pull request #276 from amansinghbais/275-fix-rule-count-and-ui
cfb40f6 
Fixed: rules total count not updating on archiving rule, showed bottom line in rule card and required astrick in case of channels (#275)
@amansinghbais amansinghbais moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform May 2, 2024
@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform May 27, 2024
ymaheshwari1 pushed a commit to ymaheshwari1/threshold-management that referenced this issue May 29, 2024
@R-Sourabh
Improved: Update the version of dxp-component(hotwax#275)
6170df8
ymaheshwari1 pushed a commit to ymaheshwari1/threshold-management that referenced this issue May 29, 2024
@R-Sourabh
Merge remote-tracking branch 'upstream/main' into hotwax#275-update-dxp
b4e1b74
ymaheshwari1 added a commit to ymaheshwari1/threshold-management that referenced this issue May 29, 2024
@ymaheshwari1
Merge pull request hotwax#243 from R-Sourabh/hotwax#275-update-dxp
d8b6367 
Improved: Update the version of dxp-component(hotwax#275)
@amansinghbais amansinghbais removed their assignment Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release-v3.0.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amansinghbais @Adameddy26