Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: rules total count not updating on archiving rule, showed bottom line in rule card and required astrick in case of channels (#275) #276

Merged

Conversation

amansinghbais
Copy link
Contributor

Related Issues

Related Issue #275

Short Description and Why It's Useful

  • Fixed total rule count not updating issue on archiving a rule.
  • Added bottom line in included facility groups item.
  • Added red astrick informing of required in channels selection in create rule.

Screenshots of Visual Changes before/after (If There Are Any)

Before
Screenshot from 2024-04-30 12-56-18

Screenshot from 2024-04-30 12-56-07

After
Screenshot from 2024-04-30 12-56-29

Screenshot from 2024-04-30 12-55-58

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

…m line in rule card and required astrick in case of channels (hotwax#275)
@ymaheshwari1 ymaheshwari1 merged commit cfb40f6 into hotwax:threshold-2.0 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants